Skip to content

fix(SpeedDial.Action): wrap with pressable #3480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 4 commits into from
Apr 27, 2022
Merged

fix(SpeedDial.Action): wrap with pressable #3480

arpitBhalla merged 4 commits into from
Apr 27, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Apr 27, 2022

Pressing the title will now also trigger the action.## Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@codecov
Copy link

codecov bot commented Apr 27, 2022 •
edited
Loading

Codecov Report

Merging #3480 (1f47678) into next (eca3f2e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 1f47678 differs from pull request most recent head 666497c. Consider uploading reports for the commit 666497c to get more accurate results

@@            Coverage Diff             @@
##             next    #3480      +/-   ##
==========================================
+ Coverage   78.51%   78.52%   +0.01%     
==========================================
  Files          87       87              
  Lines        1773     1774       +1     
  Branches      789      790       +1     
==========================================
+ Hits         1392     1393       +1     
  Misses        376      376              
  Partials        5        5
Impacted Files Coverage Δ
packages/base/src/SpeedDial/SpeedDial.tsx 96.00% <ø> (ø)
packages/base/src/SpeedDial/SpeedDial.Action.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit 6de7aa0 into react-native-elements:next Apr 27, 2022
@arpitBhalla arpitBhalla deleted the pressable-speed-dial-actions branch April 27, 2022 19:06
github-actions bot pushed a commit that referenced this pull request Apr 27, 2022
@arpitBhalla @juho-ylikyla
fix(SpeedDial.Action): wrap with pressable (#3480)
5df9859 
* fix(SpeedDial.Action): wrap with pressable

Pressing the title will now also trigger the action.

* update

Co-authored-by: juho.ylikyla <juho.ylikyla@congrid.fi>
github-actions bot pushed a commit that referenced this pull request Apr 27, 2022
@arpitBhalla @juho-ylikyla
fix(SpeedDial.Action): wrap with pressable (#3480)
465bd8e 
* fix(SpeedDial.Action): wrap with pressable

Pressing the title will now also trigger the action.

* update

Co-authored-by: juho.ylikyla <juho.ylikyla@congrid.fi>
github-actions bot pushed a commit that referenced this pull request Apr 27, 2022
@arpitBhalla @juho-ylikyla
fix(SpeedDial.Action): wrap with pressable (#3480)
6e0aa86 
* fix(SpeedDial.Action): wrap with pressable

Pressing the title will now also trigger the action.

* update

Co-authored-by: juho.ylikyla <juho.ylikyla@congrid.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arpitBhalla @juho-ylikyla