Skip to content

fix(Theming): extend default theme #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 2 commits into from
Apr 9, 2022
Merged

fix(Theming): extend default theme #3450

arpitBhalla merged 2 commits into from
Apr 9, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Apr 9, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla arpitBhalla linked an issue Apr 9, 2022 that may be closed by this pull request
Extending @rneui/themed (v4) with custom field does not work #3444
Closed
@codecov
Copy link

codecov bot commented Apr 9, 2022 •
edited
Loading

Codecov Report

Merging #3450 (2027ff7) into next (367d4ab) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             next    #3450   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files          87       87           
  Lines        1775     1775           
  Branches      786      786           
=======================================
  Hits         1389     1389           
  Misses        381      381           
  Partials        5        5
Impacted Files Coverage Δ
packages/themed/src/config/ThemeProvider.tsx 87.50% <ø> (ø)
packages/themed/src/config/makeStyles.ts 83.33% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit 587d8db into react-native-elements:next Apr 9, 2022
github-actions bot pushed a commit that referenced this pull request Apr 9, 2022
@arpitBhalla
fix(Theming): extend default theme (#3450)
45eb8eb 
* update

* update exports
github-actions bot pushed a commit that referenced this pull request Apr 9, 2022
@arpitBhalla
fix(Theming): extend default theme (#3450)
8265c38 
* update

* update exports
github-actions bot pushed a commit that referenced this pull request Apr 9, 2022
@arpitBhalla
fix(Theming): extend default theme (#3450)
eff43e6 
* update

* update exports
@lucksp lucksp mentioned this pull request Apr 26, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

Community Roadmap 🛣
Status: Closed or Merged 🏁

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extending @rneui/themed (v4) with custom field does not work

1 participant

@arpitBhalla