Skip to content

chore: fix readme & website #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 6 commits into from
Apr 8, 2022
Merged

chore: fix readme & website #3448

arpitBhalla merged 6 commits into from
Apr 8, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Apr 8, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

This was linked to issues Apr 8, 2022
Links to components in readme are incorrect, lead to Page Not Found #3443
Closed
Installation URL redirects to 404 #3447
Closed
@codecov
Copy link

codecov bot commented Apr 8, 2022 •
edited
Loading

Codecov Report

Merging #3448 (4672770) into next (ec01b65) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3448   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files          87       87           
  Lines        1775     1775           
  Branches      786      786           
=======================================
  Hits         1389     1389           
  Misses        381      381           
  Partials        5        5

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla changed the title chore: fix pkg.json, readme, website chore: fix readme & website Apr 8, 2022
@arpitBhalla arpitBhalla merged commit 58e0be4 into react-native-elements:next Apr 8, 2022
@arpitBhalla arpitBhalla deleted the readme-update branch April 8, 2022 20:33
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
@arpitBhalla
chore: fix readme & website (#3448)
bdb3716
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
@arpitBhalla
chore: fix readme & website (#3448)
45a80e9
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
@arpitBhalla
chore: fix readme & website (#3448)
e6426c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installation URL redirects to 404 Links to components in readme are incorrect, lead to Page Not Found

1 participant

@arpitBhalla