Skip to content

Conversation

@monk-lee
Copy link
Contributor

@monk-lee monk-lee commented Apr 4, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

Dimentions.removeEventListener(...) is deprecated started from RN 0.65.
https://reactnative.dev/docs/dimensions#removeeventlistener

I modified it to work well for RN 0.65+
but, it will still be warning called in RN 0.65+ until RN team officially remove removeEventListener.

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #3440 (72f43db) into next (2720463) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             next    #3440      +/-   ##
==========================================
- Coverage   78.27%   78.25%   -0.02%     
==========================================
  Files          87       87              
  Lines        1772     1775       +3     
  Branches      785      787       +2     
==========================================
+ Hits         1387     1389       +2     
- Misses        380      381       +1     
  Partials        5        5              
Impacted Files Coverage Δ
packages/base/src/Tooltip/Tooltip.tsx 89.39% <80.00%> (-1.09%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@monk-lee monk-lee changed the title Deprecated warning fix(Tooltip): removeEventListener deprecated warning Apr 4, 2022
@arpitBhalla arpitBhalla changed the title fix(Tooltip): removeEventListener deprecated warning fix(Tooltip): Dimensions deprecated listener Apr 4, 2022
@arpitBhalla arpitBhalla changed the title fix(Tooltip): Dimensions deprecated listener fix(Tooltip): removeEventListener deprecated warning Apr 4, 2022
@arpitBhalla arpitBhalla merged commit f4db70d into react-native-elements:next Apr 8, 2022
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
Co-authored-by: MONK_LEE <monk@senacorps.com>
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
Co-authored-by: MONK_LEE <monk@senacorps.com>
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
Co-authored-by: MONK_LEE <monk@senacorps.com>
@monk-lee monk-lee deleted the deprecated-warning branch April 18, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants