Skip to content

fix(ButtonGroup): render correctly in vertical mode #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 6 commits into from
May 9, 2022
Merged

fix(ButtonGroup): render correctly in vertical mode #3432

arpitBhalla merged 6 commits into from
May 9, 2022

Conversation

@kedar09
Copy link
Contributor

@kedar09 kedar09 commented Mar 31, 2022

Fixes # (issue)
This change were made in response to this issue : #3175

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • My changes generate no new warnings

Additional context

ButtonGroup - vertical issue #3175

@codecov
Copy link

codecov bot commented Mar 31, 2022 •
edited
Loading

Codecov Report

Merging #3432 (ff421dd) into next (6224af4) will decrease coverage by 0.93%.
The diff coverage is 100.00%.

❗ Current head ff421dd differs from pull request most recent head d650757. Consider uploading reports for the commit d650757 to get more accurate results

@@            Coverage Diff             @@
##             next    #3432      +/-   ##
==========================================
- Coverage   79.47%   78.53%   -0.94%     
==========================================
  Files          87       87              
  Lines        1778     1775       -3     
  Branches      772      774       +2     
==========================================
- Hits         1413     1394      -19     
- Misses        359      376      +17     
+ Partials        6        5       -1
Impacted Files Coverage Δ
packages/base/src/ButtonGroup/ButtonGroup.tsx 96.72% <100.00%> (+0.05%) ⬆️
packages/base/src/ListItem/ListItem.Accordion.tsx 8.33% <0.00%> (-71.67%) ⬇️
packages/base/src/Icon/Icon.tsx 100.00% <0.00%> (ø)
packages/base/src/Text/Text.tsx 100.00% <0.00%> (ø)
packages/base/src/Tooltip/Tooltip.tsx 89.39% <0.00%> (ø)
packages/base/src/Skeleton/Skeleton.tsx 84.61% <0.00%> (ø)
packages/base/src/Tab/Tab.tsx 57.14% <0.00%> (+0.24%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@kedar09 kedar09 changed the title ButtonGroup - render correctly in vertical mode fix(ButtonGroup) - render correctly in vertical mode Apr 3, 2022
@arpitBhalla arpitBhalla linked an issue May 9, 2022 that may be closed by this pull request
ButtonGroup doesn't render correctly in vertical mode #3175
Closed
@arpitBhalla arpitBhalla merged commit 47b8932 into react-native-elements:next May 9, 2022
@arpitBhalla arpitBhalla changed the title fix(ButtonGroup) - render correctly in vertical mode fix(ButtonGroup): render correctly in vertical mode May 9, 2022
github-actions bot pushed a commit that referenced this pull request May 9, 2022
@kedar09
fix(ButtonGroup) - render correctly in vertical mode (#3432)
1c9fd46
github-actions bot pushed a commit that referenced this pull request May 9, 2022
@kedar09
fix(ButtonGroup) - render correctly in vertical mode (#3432)
a3cc9d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

Community Roadmap 🛣
Status: Closed or Merged 🏁

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ButtonGroup doesn't render correctly in vertical mode

2 participants

@kedar09 @arpitBhalla