Skip to content

fix: change InputProps shake props optional. #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 1 commit into from
Mar 29, 2022
Merged

fix: change InputProps shake props optional. #3426

arpitBhalla merged 1 commit into from
Mar 29, 2022

Conversation

@monk-lee
Copy link
Contributor

@monk-lee monk-lee commented Mar 29, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

InputProps -> shake props should be optional.

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #3426 (439fd9a) into next (65851b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3426   +/-   ##
=======================================
  Coverage   78.22%   78.22%           
=======================================
  Files          87       87           
  Lines        1768     1768           
  Branches      780      780           
=======================================
  Hits         1383     1383           
  Misses        380      380           
  Partials        5        5
Impacted Files Coverage Δ
packages/base/src/Input/Input.tsx 65.78% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit 3567bab into react-native-elements:next Mar 29, 2022
@arpitBhalla arpitBhalla changed the title chore: change InputProps shake props optional. fix: change InputProps shake props optional. Mar 29, 2022
github-actions bot pushed a commit that referenced this pull request Mar 29, 2022
@monk-lee
chore: change InputProps shake props optional. (#3426)
02a04b9 
Co-authored-by: MONK_LEE <monk@senacorps.com>
github-actions bot pushed a commit that referenced this pull request Mar 29, 2022
@monk-lee
chore: change InputProps shake props optional. (#3426)
52b3bfa 
Co-authored-by: MONK_LEE <monk@senacorps.com>
github-actions bot pushed a commit that referenced this pull request Mar 29, 2022
@monk-lee
chore: change InputProps shake props optional. (#3426)
f36a3d5 
Co-authored-by: MONK_LEE <monk@senacorps.com>
@monk-lee monk-lee deleted the shake_optional branch March 29, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@monk-lee @arpitBhalla