Skip to content

fix(theme): replace Partial<Colors> to Colors #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 5 commits into from
Mar 27, 2022
Merged

fix(theme): replace Partial<Colors> to Colors #3418

arpitBhalla merged 5 commits into from
Mar 27, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Mar 27, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@codecov
Copy link

codecov bot commented Mar 27, 2022 •
edited
Loading

Codecov Report

Merging #3418 (8574b24) into next (fccd0d0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             next    #3418   +/-   ##
=======================================
  Coverage   78.22%   78.22%           
=======================================
  Files          87       87           
  Lines        1768     1768           
  Branches      780      780           
=======================================
  Hits         1383     1383           
  Misses        380      380           
  Partials        5        5
Impacted Files Coverage Δ
packages/base/src/CheckBox/CheckBox.tsx 93.54% <ø> (ø)
packages/base/src/Input/Input.tsx 65.78% <ø> (ø)
packages/themed/src/config/withTheme.tsx 75.67% <ø> (ø)
packages/themed/src/config/ThemeProvider.tsx 87.50% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla linked an issue Mar 27, 2022 that may be closed by this pull request
makeStyles theme parameter typing is not accurate #3394
Closed
1 task
@arpitBhalla arpitBhalla merged commit c9c2bdc into react-native-elements:next Mar 27, 2022
@arpitBhalla arpitBhalla deleted the palette branch March 27, 2022 19:24
github-actions bot pushed a commit that referenced this pull request Mar 27, 2022
@arpitBhalla
fix: remove Partial Color Type (#3418)
9af9789
github-actions bot pushed a commit that referenced this pull request Mar 27, 2022
@arpitBhalla
fix: remove Partial Color Type (#3418)
6538b8d
github-actions bot pushed a commit that referenced this pull request Mar 27, 2022
@arpitBhalla
fix: remove Partial Color Type (#3418)
d50d35a
@arpitBhalla arpitBhalla changed the title fix: remove Partial Color Type fix(theme): remove Partial Color Type Mar 28, 2022
@arpitBhalla arpitBhalla changed the title fix(theme): remove Partial Color Type fix(theme): replace Partial<Colors> to Colors Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

makeStyles theme parameter typing is not accurate

1 participant

@arpitBhalla