Skip to content

fix(TabView): swipe issue #3380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 7 commits into from
Mar 18, 2022
Merged

fix(TabView): swipe issue #3380

arpitBhalla merged 7 commits into from
Mar 18, 2022

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Mar 5, 2022 •
edited
Loading

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

This was linked to issues Mar 5, 2022
Input in Tabs TabView can't focus #3201
Closed
[TabView] onPress is not getting fire in child component in Android. #3217
Closed
@arpitBhalla arpitBhalla changed the title fix(TabView): add&prop (#3372) fix(TabView): swipe issue Mar 5, 2022
@codecov
Copy link

codecov bot commented Mar 5, 2022 •
edited
Loading

Codecov Report

Merging #3380 (dc724ad) into next (ab359f3) will decrease coverage by 0.59%.
The diff coverage is 40.90%.

❗ Current head dc724ad differs from pull request most recent head cd7da7e. Consider uploading reports for the commit cd7da7e to get more accurate results

@@            Coverage Diff             @@
##             next    #3380      +/-   ##
==========================================
- Coverage   78.88%   78.28%   -0.60%     
==========================================
  Files          87       87              
  Lines        1733     1750      +17     
  Branches      764      772       +8     
==========================================
+ Hits         1367     1370       +3     
- Misses        361      375      +14     
  Partials        5        5
Impacted Files Coverage Δ
packages/base/src/TabView/TabView.tsx 50.90% <40.90%> (-14.89%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla linked an issue Mar 5, 2022 that may be closed by this pull request
FlatList is not scrollable inside TabView #3091
Closed
@arpitBhalla arpitBhalla added this to the v4.0.0 milestone Mar 5, 2022
@arpitBhalla arpitBhalla removed a link to an issue Mar 6, 2022
[TabView] onPress is not getting fire in child component in Android. #3217
Closed
@arpitBhalla arpitBhalla mentioned this pull request Mar 17, 2022
Merged
8 tasks
@arpitBhalla arpitBhalla merged commit fc3bb93 into react-native-elements:next Mar 18, 2022
@arpitBhalla arpitBhalla deleted the tab-view branch March 18, 2022 17:36
github-actions bot pushed a commit that referenced this pull request Mar 18, 2022
@arpitBhalla
fix(TabView): swipe issue (#3380)
ed3b08b
github-actions bot pushed a commit that referenced this pull request Mar 18, 2022
@arpitBhalla
fix(TabView): swipe issue (#3380)
246485f
github-actions bot pushed a commit that referenced this pull request Mar 18, 2022
@arpitBhalla
fix(TabView): swipe issue (#3380)
bf8b259
@arpitBhalla arpitBhalla mentioned this pull request Mar 18, 2022
Closed
@uguraktas
Copy link

uguraktas commented Mar 28, 2022

When it will be release this bugfix? I have the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

Community Roadmap 🛣
Archived in project

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

Input in Tabs TabView can't focus FlatList is not scrollable inside TabView

3 participants

@arpitBhalla @uguraktas @Sinharitik589