fix(ButtonGroup): add and improve types and add tests #3220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-native-elements canceled. 🔨 Explore the source changes: f9d6e0b 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native-elements/deploys/61e1363a1a7d30000773e4d8 |
Member
|
Can you merge |
Closed
Codecov Report
@@ Coverage Diff @@
## next #3220 +/- ##
==========================================
+ Coverage 79.13% 79.24% +0.11%
==========================================
Files 87 87
Lines 1807 1807
Branches 793 792 -1
==========================================
+ Hits 1430 1432 +2
+ Misses 370 369 -1
+ Partials 7 6 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
github-actions bot
pushed a commit
that referenced
this pull request
May 21, 2022
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 21, 2022
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Improve Types(ButtonGroup)
Did you add tests for your changes?
yes.
If relevant, did you update the documentation?
it is already exists.
Summary
{element: componentName}forbuttonsprops, but TypeScript doesn't have that type, thus I added a type.buttonsis entered in an array other than a string.Does this PR introduce a breaking change?
no.
Other information
I was thinking the #3196 problem could be solved with
{element: componentName}.However, improving #3196 required modification of the parent component. This PR does not directly resolve it.