Skip to content

Conversation

@MHase
Copy link
Contributor

@MHase MHase commented Oct 31, 2018

I've noticed that some links doesn't work in docs when I want to access specific paragraph, so... here is fixed version :)

@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #1536 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1536   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files          33       33           
  Lines         612      612           
  Branches       85       85           
=======================================
  Hits          462      462           
  Misses        129      129           
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a8625...e0686aa. Read the comment docs.

@iRoachie
Copy link
Collaborator

Which doc version did you encounter this in? The changes you make here will only be available when we release a new version of the docs.

To change existing versions you have to edit the files in website/versioned-docs

@MHase
Copy link
Contributor Author

MHase commented Nov 1, 2018

I encountered it on official, public version of docs

I edited next version of the docs, because it's not so important issue, so I think it can be released with some more minor fixes :)
Or maybe in your opinion should I edit e.g. website/versioned-docs/version-1.0.0-beta7 ?

@iRoachie
Copy link
Collaborator

iRoachie commented Nov 1, 2018

Oh well okay then, it's beta anyway so i guess it's fine.

@iRoachie iRoachie merged commit 4c3dda9 into react-native-elements:next Nov 1, 2018
nurdiansyah added a commit to deboxlibrary/react-native-elements that referenced this pull request Nov 6, 2018
* commit '0126436f5f0f37e0340b0c1da32bdea5605cb6df': (43 commits)
  feat(Card): Remove flexDirection prop
  feat(Card): Remove fontFamily prop
  test: Add tests for withTheme
  test: Fix searcbar error being logged to console
  fix: Hoist statics for withTheme hoc (react-native-elements#1554)
  fix: Use library for calculating statusBar height (react-native-elements#1553)
  ref: Badge component (react-native-elements#1545)
  Set default prop for type (react-native-elements#1546)
  docs: Fix paragraphs links in docs (react-native-elements#1536)
  docs(website): Make image preview section reusable
  feat: Add button types (react-native-elements#1540)
  fix: Rounded buttons on android now work correctly (react-native-elements#1538)
  ci: Run travis against node stable
  fix: Make button height consistent when using loading
  ci: Update husky and lint-staged
  feat: Add AntDesign to list of available icon sets (react-native-elements#1529)
  docs(website): Add central place to show supported icon sets (react-native-elements#1532)
  feat(Input): Allow label to be a React element (react-native-elements#1531)
  ci: Remove expo ci from PRs (react-native-elements#1528)
  fix(Button): Make the padding consistent (react-native-elements#1505)
  ...
@Monte9
Copy link
Collaborator

Monte9 commented Mar 12, 2019

@MHase As you may (or not) know, we have an Open Collective, and we give the money to people that help to contribute to React Native Element. You did a lot of good work recently on RNE, your neat PRs and your issues helped us a lot to polish and improve the v1.0.0 🔥 + you were really comprehensive during the review 🥇

Sooo, could you please submit a $50 expense on Open Collective? Here is how to do it:

  1. Go on Open Collective

  2. Click "Submit Expense"
    Description: 1.0.0 PRs and issues
    Category: Engineering

  3. For the receipt, use this template

Feel free to reach me if you need more details 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants