chore(run-android): deprecate --deviceId in favour of --device
#2377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Unfortunately, to my knowledge, |
thymikee
reviewed
May 8, 2024
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
High5Apps
added a commit
to High5Apps/organize-rn
that referenced
this pull request
Oct 2, 2024
- Perform all changes recommended by the Upgrade Helper except: - yarn-related code. I tried switching from npm to yarn, but I couldn't figure out how to get yarn to import the info from the existing package-lock.json into yarn.lock. The switch from npm to yarn can always be done in the future - updating gradle-wrapper.jar since it is a binary file - https://react-native-community.github.io/upgrade-helper/?from=0.73.6&to=0.75.3&package=app.getorganize.organize&name=Organize - Use align-deps to update and align dependencies - Update Android studio from Iguana to Ladybug because Iguana had a max Android Gradle Plugin of 8.3.2, but 8.5.x is required - Updated react-native-pager-view from 6.2.1 to 6.4.1 to fix Android build failure - Updated react-native-vision-camera from 4.0.1 to 4.5.3 to fix Android build failure - Updated react-native-vector-icons from 10.0.3 to 10.2.0 to fix Android release build error - Removed 73 instances of defaultProps and disabled react/require-default-props in .eslintrc.js to fix warnings that defaultProps is now deprecated - All defaults (except undefined) were transferred without changes to argument defaults. It seems like many of these could be removed completely, but doing so seemed unwise since there could unanticipated side-effects from code that expected the default value instead of undefined - However, CommentList's insertedComments default of [] was changed to undefined to prevent an infinite loop that happened when navigating to a PostScreen and trying to display CommentList. I'm not sure why this happened. - Fix VerificationScreen unexpectedly showed an inputAccessory bar above the keyboard with a "Next" button by setting TextInputRow returnKeyType to none - Known Issues - `npm run ios:device:release` hangs on the install step, but this also happened before upgrading - Navigating to the Discuss tab shows a warning due to material-top-tabs. It has been fixed upstream, but hasn't been released yet. It'll likely be included in @react-navigation/material-top-tabs@6.6.15 - There's a new warning when running `npm run android:device:release` or `npm run android:device` about switching from --deviceId to --device. I attempted to do this in scripts/run-android, but it failed with "error No Android device or emulator connected." - This is a very recent change, so it'll probably be fixed soon. Until then, I'll stay on the deprecated --deviceId - react-native-community/cli#2377
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To avoid confusion between
run-androidandrun-ios, I deprecated--device-idin favour of--device. When someone will use--device-id` a warning will be presented, so that users can migrate their scripts.Test Plan:
node /path/to/react-native-cli/packages/cli/build/bin.js run-android --deviceId "asdf"Should give the warning and pass id the same way as before.
3. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-android --device "asdf"Should launch an app on passed id.
Checklist