[WIP] Change require to imports (alt)#150
[WIP] Change require to imports (alt)#150grabbou merged 6 commits intoreact-native-community:masterfrom
Conversation
|
Mind fixing conflicts and address feedback I left on #145? |
781c6ce to
d966ec4
Compare
d966ec4 to
538f651
Compare
|
@Trancever mind checking that? |
thymikee
left a comment
There was a problem hiding this comment.
Thanks so much for helping us out, it's greatly appreciated 👍
|
@thymikee I hope to help even more in the future 👍 |
|
@sidferreira amazing work, really impressive! Looks like |
|
@grabbou Change the exports will be a little trickier, as it requires changes at the tests too. Also edit: Tried a bit more and it will need a lot of (not hard, just slow) work to tweak the tests. ATM there are 2 errors related to |
|
No worries, we can do it after we merge this one. Shall we land it? |
|
If you don't have anything to add then feel free to press the button! |
* refactor(imports): replaces most uses of require by import * fix: fixes export and revert wrong change * fix: fix import order * fix: revert export change * fix: revert global-cli/index * fix: typo
|
Had to force push as I forgot to reword the PR title. |
Summary: --------- After #150 (thanks @sidferreira and @Trancever) we're finally able to use lazy module evaluation for additional perf! Before: ``` 0.70 real 0.64 user 0.12 sys ``` After: ``` 0.19 real 0.16 user 0.03 sys ``` Which gives us roughly 0.5s (~72%) improvement in startup time. With 0.2s startup time most commands feel instant now. Test Plan: ---------- No new tests added.
This is an extra for #150 Fixes exports and tweaks some tests. The `link`, `linkAssets`, and `linkDependency` where trickier as hell, but we have all tests working. I suggest take it easy in this review as I'm worried in a "false positive" in tests as there was a LOT of changes. We need to improve the code coverage for changes like this have smaller chances of failing...
No description provided.