Cleanup Connected Items in Unmount#3290
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3290 +/- ##
==========================================
+ Coverage 56.61% 56.64% +0.03%
==========================================
Files 263 263
Lines 3872 3875 +3
Branches 760 760
==========================================
+ Hits 2192 2195 +3
Misses 1679 1679
Partials 1 1
|
darthtrevino
added a commit
that referenced
this pull request
Feb 3, 2022
* fix: add hook disconnection in effect callback cleanup * chore: cut semver doc
ujaval403
reviewed
Oct 12, 2022
| connector.dropTargetOptions = options || null | ||
| connector.reconnect() | ||
| return () => connector.disconnectDropTarget() | ||
| }, [options]) |
There was a problem hiding this comment.
connector not here in dependency array so clean up not run on connector change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.