Fixes #3179 - handle custom drag sources triggering native drops#3272
Merged
darthtrevino merged 3 commits intoAug 12, 2021
Conversation
a5e0023 to
1a31238
Compare
Codecov Report
@@ Coverage Diff @@
## main #3272 +/- ##
==========================================
- Coverage 56.56% 56.56% -0.01%
==========================================
Files 263 263
Lines 3868 3870 +2
Branches 760 761 +1
==========================================
+ Hits 2188 2189 +1
- Misses 1679 1680 +1
Partials 1 1
|
Contributor
Author
|
I'm getting a failure on this PR because of a drop in code coverage - i'm not quite sure where to put a test for this behavior. We'd have to a drag interaction with a custom drag type, on an element that will trigger a native drag type - and I think it would only be effective in Firefox? Happy to write a test if someone can point me to where to do so |
darthtrevino
approved these changes
Aug 12, 2021
darthtrevino
left a comment
Member
There was a problem hiding this comment.
LGTM, I'll test this out locally first
darthtrevino
pushed a commit
that referenced
this pull request
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in Firefox where dragging links would still trigger native drag and drop behavior, even if the drag was caught as a custom defined drag type.
The codebase checks for native drag events firing, but mostly treats them separately from custom drag events. In Firefox, dragging an
<a>link will still trigger native drop behavior (following the URL), because we onlypreventDefault()if a custom drag type was not recognized in thee.dataTransferobject.This PR adds another check to the
handleTopDropCapturefunction, which will prevent default if the drop event has a native type and the drag monitor is reporting the current drag as a custom type.