fix: prevent crash in determineDropResult (react-dnd#1281)#1367
Merged
darthtrevino merged 1 commit intoreact-dnd:masterfrom Jun 4, 2019
Merged
fix: prevent crash in determineDropResult (react-dnd#1281)#1367darthtrevino merged 1 commit intoreact-dnd:masterfrom
darthtrevino merged 1 commit intoreact-dnd:masterfrom
Conversation
When target is undefined, determineDropResult crashes. I was not able to determine why `registry.getTarget` would return undefined. The issues happens sometimes when I am dragging and dropping quickly. Perhaps the drop target is getting unmounted as mentioned in react-dnd#31. I am happy to dig deeper if someone can point me in the right direction regarding which files might be relevant. This fixes react-dnd#1281.
raineorshine
added a commit
to cybersemics/em
that referenced
this pull request
Jun 1, 2019
darthtrevino
pushed a commit
that referenced
this pull request
Feb 3, 2022
When target is undefined, determineDropResult crashes. I was not able to determine why `registry.getTarget` would return undefined. The issues happens sometimes when I am dragging and dropping quickly. Perhaps the drop target is getting unmounted as mentioned in #31. I am happy to dig deeper if someone can point me in the right direction regarding which files might be relevant. This fixes #1281.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When target is undefined, determineDropResult crashes. I was not able to determine why
registry.getTargetwould return undefined. The issues happens sometimes when I am dragging and dropping quickly. Perhaps the drop target is getting unmounted as mentioned in #31.I am happy to dig deeper if someone can point me in the right direction regarding which files might be relevant.
This fixes #1281.