Skip to content

Use AT_MOST measurespec when onyl max dimension is defined#200

Merged
emilsjolander merged 1 commit into
react:masterfrom
emilsjolander:at-most-root
Jul 4, 2016
Merged

Use AT_MOST measurespec when onyl max dimension is defined#200
emilsjolander merged 1 commit into
react:masterfrom
emilsjolander:at-most-root

Conversation

@emilsjolander

Copy link
Copy Markdown
Contributor

Make use of max dimension styles to allow root to be measured with AT_MOST measurespec

@ghost ghost added the CLA Signed label Jul 2, 2016
@emilsjolander emilsjolander merged commit 6e05325 into react:master Jul 4, 2016
@emilsjolander emilsjolander deleted the at-most-root branch July 4, 2016 22:25
@molon

molon commented Jul 5, 2016

Copy link
Copy Markdown

I think this pr only support for the top-most node, it's not enough.
#201

@emilsjolander

Copy link
Copy Markdown
Contributor Author

@molon I'll follow up with another PR. thanks for pointing this out.
@rigdern This was an oversight, i'll follow up

ghost pushed a commit to react/react-native that referenced this pull request Jul 8, 2016
Summary:
react/yoga#200
Make use of max dimension styles to allow root to be measured with AT_MOST measure mode

Reviewed By: IanChilds

Differential Revision: D3513505

fbshipit-source-id: 169f49717e896eb6270b52fb7115ce005aa0e3a8
@emilsjolander emilsjolander restored the at-most-root branch July 8, 2016 12:59
@emilsjolander emilsjolander deleted the at-most-root branch July 8, 2016 13:34
@emilsjolander

Copy link
Copy Markdown
Contributor Author

@rigdern #203

emilsjolander added a commit that referenced this pull request Jul 8, 2016
Add missing js implementation for PR #200
jordwalke added a commit to jordwalke/css-layout that referenced this pull request Oct 7, 2016
tungdo194 pushed a commit to tungdo194/rn-test that referenced this pull request Apr 28, 2024
Summary:
react/yoga#200
Make use of max dimension styles to allow root to be measured with AT_MOST measure mode

Reviewed By: IanChilds

Differential Revision: D3513505

fbshipit-source-id: 169f49717e896eb6270b52fb7115ce005aa0e3a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants