Use react-transition-group from npm#9937
Merged
Merged
Conversation
Contributor
|
If/when I have time I can come back to this and manually test it. I think we could use the 'browserify' fixture and require and use it there to manually test. |
Collaborator
Author
|
I'm going to assume it works—I'll do another round of testing anyway as I complete preparing this, and I'd rather test them all at once. |
Contributor
|
Looks like it should work to me...i don't think I changed the exports at all 👍 |
nhunzaker
pushed a commit
to nhunzaker/react
that referenced
this pull request
Jun 13, 2017
1 task
This was referenced Aug 26, 2019
This was referenced Sep 22, 2019
This was referenced Jan 23, 2020
This was referenced Feb 23, 2020
This was referenced Mar 18, 2020
This was referenced Mar 27, 2020
This was referenced May 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I have not tested this yet.
This should point
react-addons-transition-groupto API-compatible versions ofreact-transition-grouppackage. This lets it keep working in observable future. So we don't need to deprecate it officially (even though we will keep the npm package deprecated and suggest people to migrate to new package explicitly).cc @jquense