Skip to content

Adds CSS Grid properties to list of unitless numbers#9185

Merged
flarnie merged 1 commit into
react:masterfrom
ericsakmar:css-grid-properties
Apr 20, 2017
Merged

Adds CSS Grid properties to list of unitless numbers#9185
flarnie merged 1 commit into
react:masterfrom
ericsakmar:css-grid-properties

Conversation

@ericsakmar

@ericsakmar ericsakmar commented Mar 15, 2017

Copy link
Copy Markdown
Contributor

Adds the following CSS Grid properties to the list of unitless numbers:

  • gridColumnStart
  • gridColumnEnd
  • gridColumnSpan (ie/ms only)
  • gridRowStart
  • gridRowEnd
  • gridRowSpan (ie/ms only)

Without these values in the list, the code appends a px, which is not valid for these properties.

@gaearon

gaearon commented Apr 18, 2017

Copy link
Copy Markdown
Collaborator

Is this list exhaustive?

@flarnie flarnie mentioned this pull request Apr 18, 2017
Closed
49 tasks
@ericsakmar

ericsakmar commented Apr 18, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

It's exhaustive to the CSS grid spec, but not necessarily exhaustive to other newer unitless properties outside of that spec.

@flarnie flarnie self-assigned this Apr 20, 2017
@flarnie

flarnie commented Apr 20, 2017

Copy link
Copy Markdown
Contributor

Initially my questions were:

  1. Is it too soon to add CSS Grid syntax to React? What if the spec changes?
  2. Does this miss any other CSS Grid properties?

Clearly though if we already support gridColumn and gridRow then we should support the more specific grid properties too. And it looks like this does not miss any other non-px grid properties.

Thanks for submitting this @ericsakmar!

@flarnie flarnie merged commit 6488229 into react:master Apr 20, 2017
@flarnie flarnie added this to the 15.6 milestone Apr 20, 2017
flarnie pushed a commit that referenced this pull request Apr 20, 2017
@ericsakmar @flarnie
Adds CSS Grid properties to list of unitless numbers (#9185)
25177ec
@gaearon gaearon mentioned this pull request May 29, 2017
Closed
flarnie pushed a commit to flarnie/react that referenced this pull request Jun 7, 2017
@ericsakmar @flarnie
Adds CSS Grid properties to list of unitless numbers (react#9185)
15dcadf
@acusti acusti mentioned this pull request Nov 1, 2017
Closed
@renovate renovate Bot mentioned this pull request Feb 2, 2018
Closed
1 task
mgol added a commit to mgol/react that referenced this pull request Sep 4, 2018
@mgol
Add gridArea to unitless CSS properties
c4f1d23 
Ref react#9185
@mgol mgol mentioned this pull request Sep 4, 2018
Merged
gaearon pushed a commit that referenced this pull request Sep 4, 2018
@mgol @gaearon
Add gridArea to unitless CSS properties (#13550)
25d48a7 
Ref #9185
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@mgol @jetoneza
Add gridArea to unitless CSS properties (react#13550)
d4ea4f9 
Ref react#9185
This was referenced Aug 26, 2019
Open
Open
This was referenced Sep 22, 2019
Open
Open
Open
Open
This was referenced Jan 23, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 9, 2020
Open
This was referenced Feb 23, 2020
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 3, 2020
Open
This was referenced Mar 18, 2020
Merged
Closed
Merged
This was referenced Mar 27, 2020
Closed
Open
This was referenced Apr 7, 2020
Open
Open
Open
This was referenced May 6, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@flarnie flarnie

Labels

CLA Signed

Projects

None yet

Milestone

15.6

Development

Successfully merging this pull request may close these issues.

4 participants

@ericsakmar @gaearon @flarnie @facebook-github-bot