Skip to content

Remove unnecessary null#8858

Merged
gaearon merged 2 commits into
react:masterfrom
edvinerikson:patch-1
Jan 24, 2017
Merged

Remove unnecessary null#8858
gaearon merged 2 commits into
react:masterfrom
edvinerikson:patch-1

Conversation

@edvinerikson

@edvinerikson edvinerikson commented Jan 24, 2017

Copy link
Copy Markdown
Contributor

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint).
  6. Run the Flow typechecks (npm run flow).
  7. If you added or removed any tests, run ./scripts/fiber/record-tests before submitting the pull request, and commit the resulting changes.
  8. If you haven't already, complete the CLA.

@edvinerikson edvinerikson mentioned this pull request Jan 24, 2017
Merged
@gaearon

gaearon commented Jan 24, 2017

Copy link
Copy Markdown
Collaborator

Now that I think of it why do we ever return null now? Let's change it to always fall back to "Component".

@gaearon gaearon self-assigned this Jan 24, 2017
@edvinerikson

edvinerikson commented Jan 24, 2017

Copy link
Copy Markdown
Contributor Author

Not sure what circleci is up to but I ran the tests and flow locally without any errors

@gaearon

gaearon commented Jan 24, 2017

Copy link
Copy Markdown
Collaborator

k

@gaearon gaearon merged commit 5170db8 into react:master Jan 24, 2017
@edvinerikson edvinerikson deleted the patch-1 branch January 24, 2017 18:32
@sophiebits

sophiebits commented Jan 24, 2017

Copy link
Copy Markdown
Collaborator

You don't think Unknown is nicer? We use that as a fallback for the stack, for instance.

@gaearon gaearon mentioned this pull request Jan 24, 2017
Merged
@gaearon

gaearon commented Jan 24, 2017

Copy link
Copy Markdown
Collaborator

That probably broke the CI :P.
I agree, let's change to "Unknown".

@edvinerikson

edvinerikson commented Jan 25, 2017

Copy link
Copy Markdown
Contributor Author

should I send a PR?

@gaearon

gaearon commented Jan 25, 2017

Copy link
Copy Markdown
Collaborator

Please do

@edvinerikson edvinerikson mentioned this pull request Jan 25, 2017
Merged
georgespeelman02-create pushed a commit to georgespeelman02-create/react that referenced this pull request Jun 5, 2026
fix: auto-implement software boundaries for issue react#8858 - submit…
cc453d8 
…ted by George Speelman
georgespeelman02-create pushed a commit to georgespeelman02-create/react that referenced this pull request Jun 5, 2026
fix: auto-implement software boundaries for issue react#8858 - submit…
2e93f3d 
…ted by George Speelman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gaearon gaearon

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edvinerikson @gaearon @sophiebits @facebook-github-bot