[compiler] Repro for false positive mutation of a value derived from props#35139
Merged
Conversation
…props Repro from the compiler WG (Thanks Cody!) of a case where the compiler incorrectly thinks a value is mutable.
poteto
approved these changes
Nov 14, 2025
poteto
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for looking into this!
josephsavona
added a commit
that referenced
this pull request
Nov 14, 2025
Fix for the repro from the previous PR. A `Capture x -> y` effect should downgrade to `ImmutableCapture` when the source value is maybe-frozen. MaybeFrozen represents the union of a frozen value with a non-frozen value. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35140). * __->__ #35140 * #35139
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 14, 2025
Fix for the repro from the previous PR. A `Capture x -> y` effect should downgrade to `ImmutableCapture` when the source value is maybe-frozen. MaybeFrozen represents the union of a frozen value with a non-frozen value. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35140). * __->__ #35140 * #35139 DiffTrain build for [19b769f](19b769f)
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 14, 2025
Fix for the repro from the previous PR. A `Capture x -> y` effect should downgrade to `ImmutableCapture` when the source value is maybe-frozen. MaybeFrozen represents the union of a frozen value with a non-frozen value. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35140). * __->__ #35140 * #35139 DiffTrain build for [19b769f](19b769f)
manNomi
pushed a commit
to manNomi/react
that referenced
this pull request
Nov 15, 2025
…props (react#35139) Repro from the compiler WG (Thanks Cody!) of a case where the compiler incorrectly thinks a value is mutable. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35139). * react#35140 * __->__ react#35139
manNomi
pushed a commit
to manNomi/react
that referenced
this pull request
Nov 15, 2025
) Fix for the repro from the previous PR. A `Capture x -> y` effect should downgrade to `ImmutableCapture` when the source value is maybe-frozen. MaybeFrozen represents the union of a frozen value with a non-frozen value. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35140). * __->__ react#35140 * react#35139
unstubbable
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 15, 2025
[diff react/react@93fc5740...fb2177c1](react/react@93fc574...fb2177c) <details> <summary>React upstream changes</summary> - react/react#35143 - react/react#35145 - react/react#35140 - react/react#35139 - react/react#35062 - react/react#35135 - react/react#35134 </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro from the compiler WG (Thanks Cody!) of a case where the compiler incorrectly thinks a value is mutable.
Stack created with Sapling. Best reviewed with ReviewStack.