Skip to content

Enable disableDefaultPropsExceptForClasses#31804

Merged
rickhanlonii merged 1 commit into
react:mainfrom
rickhanlonii:rh/ff-default-props-rtr
Dec 17, 2024
Merged

Enable disableDefaultPropsExceptForClasses#31804
rickhanlonii merged 1 commit into
react:mainfrom
rickhanlonii:rh/ff-default-props-rtr

Conversation

@rickhanlonii

Copy link
Copy Markdown
Contributor

TODO: test this PR to see what internal tests fail

@vercel

vercel Bot commented Dec 16, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 3:03pm

@react-sizebot

Copy link
Copy Markdown

Comparing: e06c72fcf4632ad3117add713a25f6354631f037...6fce6f2f0b4718f7f6fe9411d8c00220e1f2acfa

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.76 kB 510.76 kB = 91.36 kB 91.36 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.55 kB 515.55 kB = 92.17 kB 92.17 kB
facebook-www/ReactDOM-prod.classic.js = 594.69 kB 594.69 kB = 104.93 kB 104.93 kB
facebook-www/ReactDOM-prod.modern.js = 584.96 kB 584.96 kB = 103.37 kB 103.37 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactTestRenderer-dev.classic.js = 575.13 kB 570.88 kB = 94.06 kB 93.58 kB
facebook-www/ReactTestRenderer-dev.modern.js = 575.12 kB 570.88 kB = 94.06 kB 93.58 kB

Generated by 🚫 dangerJS against d7fad4e

@rickhanlonii rickhanlonii marked this pull request as ready for review December 17, 2024 03:51
@rickhanlonii rickhanlonii merged commit 49b1a95 into react:main Dec 17, 2024
@rickhanlonii rickhanlonii deleted the rh/ff-default-props-rtr branch December 17, 2024 03:51
github-actions Bot pushed a commit that referenced this pull request Dec 17, 2024
TODO: test this PR to see what internal tests fail

DiffTrain build for [49b1a95](49b1a95)
davesnx added a commit to davesnx/react that referenced this pull request Dec 18, 2024
…act into issue-31578-setter-arity-gcc

* 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react:
  [flags] Clean up scheduler flags (react#31814)
  Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761)
  Enable disableDefaultPropsExceptForClasses (react#31804)
  Turn on useModernStrictMode in test renderers (react#31769)
  [compiler][ez] Add shape for global Object.keys (react#31583)
  [compiler] Context variables as dependencies (react#31582)
  [compiler] Add fire to known React APIs (react#31795)
  [compiler] Add option for firing effect functions (react#31794)
  [compiler][be] Logger based debug printing in test runner (react#31809)
  [compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581)
  [compiler] Repro for aliased captures within inner function expressions (react#31770)
  [compiler][be] Playground now compiles entire program (react#31774)
  [Flight] Color and badge non-primary environments (react#31738)
  [Flight] Emit Deduped Server Components Marker (react#31737)
  [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736)
  Clean up context access profiling experiment (react#31806)
  [Flight] Stack Parallel Components in Separate Tracks (react#31735)
  Flag for requestPaint (react#31805)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants