feat<Compiler>: consider that the dispatch function from useReducer is non-reactive#29705
Merged
josephsavona merged 4 commits intoJun 5, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
useReducer is non-reactiveuseReducer is non-reactive
useReducer is non-reactiveuseReducer is non-reactive
|
Comparing: d77dd31...8353f1f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
josephsavona
reviewed
Jun 1, 2024
josephsavona
left a comment
Contributor
There was a problem hiding this comment.
Exciting, thanks for putting up a PR! Just some quick feedback, will do a full review next week
Contributor
Author
|
Thanks for your review! The required changes have been made. |
josephsavona
suggested changes
Jun 3, 2024
josephsavona
left a comment
Contributor
There was a problem hiding this comment.
Looks like you need to run prettier
9574ce4 to
086dafe
Compare
086dafe to
610cde5
Compare
Contributor
Author
|
Oh, I forgot. Now it's fixed. |
610cde5 to
8353f1f
Compare
Contributor
|
Awesome, thanks! |
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
… is non-reactive (#29705) Summary The dispatch function from useReducer is stable, so it is also non-reactive. the related PR: #29665 the related comment: #29674 (comment) I am not sure if the location of the new test file is appropriate😅. How did you test this change? Added the specific test compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/useReducer-returned-dispatcher-is-non-reactive.expect.md. DiffTrain build for commit 704aeed.
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dispatch function from
useReduceris stable, so it is also non-reactive.the related PR: #29665
the related comment: #29674 (comment)
I am not sure if the location of the new test file is appropriate😅.
How did you test this change?
Added the specific test
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/useReducer-returned-dispatcher-is-non-reactive.expect.md.