Skip to content

[Flight Reply] retain listeners when resolving models with existing listeners#29207

Merged
gnoff merged 1 commit into
react:mainfrom
gnoff:listener-fix-to-reply-client
May 21, 2024
Merged

[Flight Reply] retain listeners when resolving models with existing listeners#29207
gnoff merged 1 commit into
react:mainfrom
gnoff:listener-fix-to-reply-client

Conversation

@gnoff

@gnoff gnoff commented May 21, 2024

Copy link
Copy Markdown
Contributor

In #29201 a fix was made to ensure we don't "forget" about some listeners when handling cyclic chunks.
In #29204 another fix was made for a special case when the chunk already has listeners before it first resolves.

This implements the followup fix for Flight Reply which was originally missed in #29204

@gnoff @lubieowoce
[Flight Reply] retain listeners when resolving models with existing l…
c7c7ef2 
…isteners

In react#29201 a fix was made to ensure we don't "forget" about some listeners when handling cyclic chunks.
In react#29204 another fix was made for a special case when the chunk already has listeners before it first resolves.

This implements the followup fix for Flight Reply which was originally missed in react#29204

Co-Authored-by: Janka Uryga <lolzatu2@gmail.com>
@vercel

vercel Bot commented May 21, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 11:07pm

@gnoff gnoff requested a review from sebmarkbage May 21, 2024 23:02
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 21, 2024
@react-sizebot

react-sizebot commented May 21, 2024

Copy link
Copy Markdown

Comparing: 0f58454...c7c7ef2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 495.71 kB 495.71 kB = 88.78 kB 88.78 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 500.51 kB 500.51 kB = 89.47 kB 89.47 kB
facebook-www/ReactDOM-prod.classic.js = 592.86 kB 592.86 kB = 104.28 kB 104.28 kB
facebook-www/ReactDOM-prod.modern.js = 569.08 kB 569.08 kB = 100.69 kB 100.69 kB
test_utils/ReactAllWarnings.js Deleted 64.35 kB 0.00 kB Deleted 16.05 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js +0.43% 83.42 kB 83.78 kB +0.40% 17.56 kB 17.63 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js +0.43% 83.42 kB 83.78 kB +0.40% 17.56 kB 17.63 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js +0.42% 85.70 kB 86.06 kB +0.46% 17.75 kB 17.83 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js +0.42% 85.70 kB 86.06 kB +0.46% 17.75 kB 17.83 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js +0.42% 86.02 kB 86.38 kB +0.35% 17.86 kB 17.92 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js +0.42% 86.02 kB 86.38 kB +0.35% 17.86 kB 17.92 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js +0.42% 86.47 kB 86.83 kB +0.37% 17.99 kB 18.06 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js +0.42% 86.47 kB 86.83 kB +0.37% 17.99 kB 18.06 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js +0.42% 86.50 kB 86.86 kB +0.37% 17.99 kB 18.05 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js +0.42% 86.50 kB 86.86 kB +0.37% 17.99 kB 18.05 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js +0.41% 88.08 kB 88.44 kB +0.37% 18.25 kB 18.32 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js +0.40% 88.91 kB 89.27 kB +0.39% 18.43 kB 18.50 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js +0.40% 88.91 kB 89.27 kB +0.39% 18.43 kB 18.50 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js +0.40% 88.93 kB 89.29 kB +0.38% 18.44 kB 18.51 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js +0.40% 88.93 kB 89.29 kB +0.38% 18.44 kB 18.51 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js +0.40% 89.86 kB 90.22 kB +0.38% 18.64 kB 18.71 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js +0.40% 89.86 kB 90.22 kB +0.38% 18.64 kB 18.71 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js +0.40% 89.89 kB 90.25 kB +0.38% 18.63 kB 18.70 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js +0.40% 89.89 kB 90.25 kB +0.38% 18.63 kB 18.70 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js +0.40% 90.41 kB 90.77 kB +0.37% 18.45 kB 18.52 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js +0.40% 90.73 kB 91.09 kB +0.35% 18.55 kB 18.61 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js +0.39% 91.27 kB 91.63 kB +0.35% 18.69 kB 18.76 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js +0.39% 91.29 kB 91.65 kB +0.35% 18.69 kB 18.75 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js +0.38% 93.58 kB 93.94 kB +0.37% 19.11 kB 19.18 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js +0.38% 93.59 kB 93.95 kB +0.37% 19.12 kB 19.19 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js +0.38% 94.52 kB 94.88 kB +0.34% 19.33 kB 19.40 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js +0.38% 94.55 kB 94.91 kB +0.34% 19.33 kB 19.39 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.25% 158.83 kB 159.22 kB +0.18% 34.92 kB 34.98 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.25% 158.83 kB 159.22 kB +0.18% 34.92 kB 34.98 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.24% 164.47 kB 164.86 kB +0.19% 36.10 kB 36.17 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.24% 164.47 kB 164.86 kB +0.19% 36.10 kB 36.17 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.24% 165.17 kB 165.56 kB +0.17% 36.35 kB 36.41 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.24% 165.17 kB 165.56 kB +0.17% 36.35 kB 36.41 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.24% 165.71 kB 166.10 kB +0.19% 36.38 kB 36.45 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.24% 165.71 kB 166.10 kB +0.19% 36.38 kB 36.45 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.24% 165.90 kB 166.29 kB +0.19% 36.45 kB 36.52 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.24% 165.90 kB 166.29 kB +0.19% 36.45 kB 36.52 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.23% 166.70 kB 167.09 kB +0.18% 36.34 kB 36.41 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.23% 166.70 kB 167.09 kB +0.18% 36.34 kB 36.41 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.23% 166.89 kB 167.28 kB +0.17% 36.40 kB 36.47 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.23% 166.89 kB 167.28 kB +0.17% 36.40 kB 36.47 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.23% 169.34 kB 169.73 kB +0.18% 37.14 kB 37.21 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.23% 169.34 kB 169.73 kB +0.18% 37.14 kB 37.21 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.23% 169.52 kB 169.91 kB +0.18% 37.22 kB 37.28 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.23% 169.52 kB 169.91 kB +0.18% 37.22 kB 37.28 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.23% 171.54 kB 171.93 kB +0.17% 37.74 kB 37.80 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.22% 176.53 kB 176.92 kB +0.17% 38.70 kB 38.77 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.22% 177.23 kB 177.62 kB +0.16% 38.95 kB 39.01 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.22% 178.45 kB 178.84 kB +0.17% 39.21 kB 39.27 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.22% 178.63 kB 179.02 kB +0.17% 39.28 kB 39.35 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.22% 179.41 kB 179.80 kB +0.15% 39.16 kB 39.22 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.22% 179.60 kB 179.99 kB +0.15% 39.23 kB 39.29 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.21% 182.05 kB 182.44 kB +0.16% 39.97 kB 40.03 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.21% 182.23 kB 182.62 kB +0.16% 40.05 kB 40.11 kB
test_utils/ReactAllWarnings.js Deleted 64.35 kB 0.00 kB Deleted 16.05 kB 0.00 kB

Generated by 🚫 dangerJS against c7c7ef2

@gnoff gnoff merged commit 81c5ff2 into react:main May 21, 2024
@gnoff gnoff deleted the listener-fix-to-reply-client branch May 21, 2024 23:16
@gnoff gnoff restored the listener-fix-to-reply-client branch May 21, 2024 23:59
@ztanner ztanner mentioned this pull request May 22, 2024
Merged
sebmarkbage
sebmarkbage reviewed May 22, 2024
View reviewed changes

@sebmarkbage sebmarkbage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

@gnoff gnoff deleted the listener-fix-to-reply-client branch May 22, 2024 00:52
@eps1lon eps1lon mentioned this pull request May 22, 2024
Merged
ztanner pushed a commit to vercel/next.js that referenced this pull request May 23, 2024
@eps1lon
Update React from 81c5ff2e04 to f994737d14 (#66093)
e421fea 
<details>
<summary>React upstream changes</summary>

- react/react#29219
- react/react#29007
- react/react#29207

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sebmarkbage sebmarkbage sebmarkbage left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gnoff @react-sizebot @sebmarkbage @facebook-github-bot