Skip to content

Allow specifying timeout in tests via third argument#29006

Merged
eps1lon merged 1 commit into
react:mainfrom
eps1lon:strictEffects/test-timeout
May 7, 2024
Merged

Allow specifying timeout in tests via third argument#29006
eps1lon merged 1 commit into
react:mainfrom
eps1lon:strictEffects/test-timeout

Conversation

@eps1lon

@eps1lon eps1lon commented May 6, 2024

Copy link
Copy Markdown
Collaborator

Summary

Enables extending the timeout via test(name, callback, timeoutMS) when the test is gated. Extending the timeout is mostly useful with a debugger attached. With the debugger attached, you easily exceed the 5s timeout.

How did you test this change?

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 6, 2024
@react-sizebot

Copy link
Copy Markdown

Comparing: 9b13002...19900a5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 492.61 kB 492.61 kB = 87.88 kB 87.88 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 498.86 kB 498.86 kB = 88.92 kB 88.92 kB
facebook-www/ReactDOM-prod.classic.js = 591.22 kB 591.22 kB = 103.96 kB 103.96 kB
facebook-www/ReactDOM-prod.modern.js = 567.44 kB 567.44 kB = 100.36 kB 100.36 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 19900a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants