[Debug Tools] Always use includeHooksSource option#28309
Merged
Conversation
|
Comparing: 32df74d...d422a4f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
c2db0a7 to
0e01326
Compare
This option was added defensively but it's not needed. There's no cost to including it always. I suspect this optional was added mainly to avoid needing to update tests. That's not a reason to have an unnecessary public API though. We have a praxis for dealing with source location in tests to avoid them failing tests.
0e01326 to
d422a4f
Compare
Contributor
Author
|
@hoxyq I fixed the tests so should be good now. |
hoxyq
approved these changes
Feb 14, 2024
This was referenced Feb 20, 2024
hoxyq
added a commit
that referenced
this pull request
Feb 22, 2024
Full list of changes (not a public CHANGELOG): * feature[REMOVED][devtools]: turn off / hide location based component filters ([hoxyq](https://github.com/hoxyq) in [#28417](#28417)) * Add useSyncExternalStore and useTransition to getPrimitiveStackCache ([jamesbvaughan](https://github.com/jamesbvaughan) in [#28399](#28399)) * chore[devtools]: use react-window from npm and bump react-virtualized-auto-sizer to ^1.0.23 ([hoxyq](https://github.com/hoxyq) in [#28408](#28408)) * Pass ref as normal prop ([acdlite](https://github.com/acdlite) in [#28348](#28348)) * Combine createElement and JSX modules ([acdlite](https://github.com/acdlite) in [#28320](#28320)) * [Debug Tools] Always use includeHooksSource option ([sebmarkbage](https://github.com/sebmarkbage) in [#28309](#28309)) * Revert "[Tests] Reset modules by default" ([acdlite](https://github.com/acdlite) in [#28318](#28318)) * Switch <Context> to mean <Context.Provider> ([gaearon](https://github.com/gaearon) in [#28226](#28226)) * [Debug Tools] Introspect Promises in use() ([sebmarkbage](https://github.com/sebmarkbage) in [#28297](#28297)) * fix[devtools/useModalDismissSignal]: use getRootNode for shadow root case support ([hoxyq](https://github.com/hoxyq) in [#28145](#28145)) * fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode and synchronous act ([hoxyq](https://github.com/hoxyq) in [#28296](#28296)) * chore: gate legacy apis for react-devtools-shell ([hoxyq](https://github.com/hoxyq) in [#28273](#28273)) * DevTools: Add support for use(Context) ([eps1lon](https://github.com/eps1lon) in [#28233](#28233)) * Remove __self and __source location from elements ([sebmarkbage](https://github.com/sebmarkbage) in [#28265](#28265)) * chore: use versioned render in inspectedElement test ([hoxyq](https://github.com/hoxyq) in [#28246](#28246)) * chore: use versioned render in TimelineProfiler test and gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in [#28218](#28218)) * [Tests] Reset modules by default ([rickhanlonii](https://github.com/rickhanlonii) in [#28254](#28254)) * chore: use versioned render in preprocessData test and gate some for … ([hoxyq](https://github.com/hoxyq) in [#28219](#28219)) * chore: use versioned render in storeStressSync test and gate them for legacy rendering ([hoxyq](https://github.com/hoxyq) in [#28216](#28216)) * Patch devtools before running useMemo function in strict mode ([gsathya](https://github.com/gsathya) in [#28249](#28249)) * chore: use versioned render in storeComponentFilters test ([hoxyq](https://github.com/hoxyq) in [#28241](#28241)) * chore: use versioned render in profilerContext test ([hoxyq](https://github.com/hoxyq) in [#28243](#28243)) * chore: use versioned render in profilingCommitTreeBuilder test and gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in [#28236](#28236)) * chore: use versioned render in profilingHostRoot test and gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in [#28237](#28237)) * chore: use versioned render in profilingCache test ([hoxyq](https://github.com/hoxyq) in [#28242](#28242)) * chore: use versioned render in ownersListContext test ([hoxyq](https://github.com/hoxyq) in [#28240](#28240)) * chore: use versioned render in editing test ([hoxyq](https://github.com/hoxyq) in [#28239](#28239)) * chore: use versioned render in treeContext test ([hoxyq](https://github.com/hoxyq) in [#28245](#28245)) * chore: use versioned render in store test ([hoxyq](https://github.com/hoxyq) in [#28244](#28244)) * chore: use versioned render in profilerStore test ([hoxyq](https://github.com/hoxyq) in [#28238](#28238)) * chore: use versioned render in profilingCharts test ([hoxyq](https://github.com/hoxyq) in [#28235](#28235)) * chore: use versioned render in profilerChangeDescriptions test ([hoxyq](https://github.com/hoxyq) in [#28221](#28221)) * chore: use versioned render in storeOwners test ([hoxyq](https://github.com/hoxyq) in [#28215](#28215)) * chore: use versioned render in componentStacks test ([hoxyq](https://github.com/hoxyq) in [#28214](#28214)) * chore: use versioned render in console test ([hoxyq](https://github.com/hoxyq) in [#28213](#28213)) * chore: use versioned render in useEditableValue test ([hoxyq](https://github.com/hoxyq) in [#28212](#28212)) * chore: use versioned render in FastRefreshDevToolsIntegration test ([hoxyq](https://github.com/hoxyq) in [#28211](#28211)) * chore: add versioned render implementation for DevTools tests ([hoxyq](https://github.com/hoxyq) in [#28210](#28210)) * chore: add single versioned implementation of act for DevTools tests ([hoxyq](https://github.com/hoxyq) in [#28186](#28186)) * DevTools: Add support for useFormState ([eps1lon](https://github.com/eps1lon) in [#28232](#28232)) * DevTools: Add support for useOptimistic Hook ([eps1lon](https://github.com/eps1lon) in [#27982](#27982)) * Add stable React.act export ([acdlite](https://github.com/acdlite) in [#28160](#28160)) * [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in [#27871](#27871)) * fix[devtools/e2e]: add fallback for act in integration tests ([hoxyq](https://github.com/hoxyq) in [#27842](#27842)) * Add stable concurrent option to react-test-renderer ([jackpope](https://github.com/jackpope) in [#27804](#27804)) * Update act references in tests ([gnoff](https://github.com/gnoff) in [#27805](#27805)) * Flow: make more objects exact ([kassens](https://github.com/kassens) in [#27790](#27790))
huozhi
added a commit
to vercel/next.js
that referenced
this pull request
Feb 23, 2024
### React upstream changes - react/react#28333 - react/react#28334 - react/react#28378 - react/react#28377 - react/react#28376 - react/react#28338 - react/react#28331 - react/react#28336 - react/react#28320 - react/react#28317 - react/react#28375 - react/react#28367 - react/react#28380 - react/react#28368 - react/react#28343 - react/react#28355 - react/react#28374 - react/react#28362 - react/react#28344 - react/react#28339 - react/react#28353 - react/react#28346 - react/react#25790 - react/react#28352 - react/react#28326 - react/react#27688 - react/react#28329 - react/react#28332 - react/react#28340 - react/react#28327 - react/react#28325 - react/react#28324 - react/react#28309 - react/react#28310 - react/react#28307 - react/react#28306 - react/react#28315 - react/react#28318 - react/react#28226 - react/react#28308 - react/react#27563 - react/react#28297 - react/react#28286 - react/react#28284 - react/react#28275 - react/react#28145 - react/react#28301 - react/react#28224 - react/react#28152 - react/react#28296 - react/react#28294 - react/react#28279 - react/react#28273 - react/react#28269 - react/react#28376 - react/react#28338 - react/react#28331 - react/react#28336 - react/react#28320 - react/react#28317 - react/react#28375 - react/react#28367 - react/react#28380 - react/react#28368 - react/react#28343 - react/react#28355 - react/react#28374 - react/react#28362 - react/react#28344 - react/react#28339 - react/react#28353 - react/react#28346 - react/react#25790 - react/react#28352 - react/react#28326 - react/react#27688 - react/react#28329 - react/react#28332 - react/react#28340 - react/react#28327 - react/react#28325 - react/react#28324 - react/react#28309 - react/react#28310 - react/react#28307 - react/react#28306 - react/react#28315 - react/react#28318 - react/react#28226 - react/react#28308 - react/react#27563 - react/react#28297 - react/react#28286 - react/react#28284 - react/react#28275 - react/react#28145 - react/react#28301 - react/react#28224 - react/react#28152 - react/react#28296 - react/react#28294 - react/react#28279 - react/react#28273 - react/react#28269 Closes NEXT-2542 Disable ppr test for strict mode for now, @acdlite will check it and we'll sync again
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
This option was added defensively but it's not needed. There's no cost to including it always. I suspect this optional was added mainly to avoid needing to update tests. That's not a reason to have an unnecessary public API though. We have a praxis for dealing with source location in tests to avoid them failing tests. I also ported them to inline snapshots so that additions to the protocol isn't such a pain.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Full list of changes (not a public CHANGELOG): * feature[REMOVED][devtools]: turn off / hide location based component filters ([hoxyq](https://github.com/hoxyq) in [react#28417](react#28417)) * Add useSyncExternalStore and useTransition to getPrimitiveStackCache ([jamesbvaughan](https://github.com/jamesbvaughan) in [react#28399](react#28399)) * chore[devtools]: use react-window from npm and bump react-virtualized-auto-sizer to ^1.0.23 ([hoxyq](https://github.com/hoxyq) in [react#28408](react#28408)) * Pass ref as normal prop ([acdlite](https://github.com/acdlite) in [react#28348](react#28348)) * Combine createElement and JSX modules ([acdlite](https://github.com/acdlite) in [react#28320](react#28320)) * [Debug Tools] Always use includeHooksSource option ([sebmarkbage](https://github.com/sebmarkbage) in [react#28309](react#28309)) * Revert "[Tests] Reset modules by default" ([acdlite](https://github.com/acdlite) in [react#28318](react#28318)) * Switch <Context> to mean <Context.Provider> ([gaearon](https://github.com/gaearon) in [react#28226](react#28226)) * [Debug Tools] Introspect Promises in use() ([sebmarkbage](https://github.com/sebmarkbage) in [react#28297](react#28297)) * fix[devtools/useModalDismissSignal]: use getRootNode for shadow root case support ([hoxyq](https://github.com/hoxyq) in [react#28145](react#28145)) * fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode and synchronous act ([hoxyq](https://github.com/hoxyq) in [react#28296](react#28296)) * chore: gate legacy apis for react-devtools-shell ([hoxyq](https://github.com/hoxyq) in [react#28273](react#28273)) * DevTools: Add support for use(Context) ([eps1lon](https://github.com/eps1lon) in [react#28233](react#28233)) * Remove __self and __source location from elements ([sebmarkbage](https://github.com/sebmarkbage) in [react#28265](react#28265)) * chore: use versioned render in inspectedElement test ([hoxyq](https://github.com/hoxyq) in [react#28246](react#28246)) * chore: use versioned render in TimelineProfiler test and gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in [react#28218](react#28218)) * [Tests] Reset modules by default ([rickhanlonii](https://github.com/rickhanlonii) in [react#28254](react#28254)) * chore: use versioned render in preprocessData test and gate some for … ([hoxyq](https://github.com/hoxyq) in [react#28219](react#28219)) * chore: use versioned render in storeStressSync test and gate them for legacy rendering ([hoxyq](https://github.com/hoxyq) in [react#28216](react#28216)) * Patch devtools before running useMemo function in strict mode ([gsathya](https://github.com/gsathya) in [react#28249](react#28249)) * chore: use versioned render in storeComponentFilters test ([hoxyq](https://github.com/hoxyq) in [react#28241](react#28241)) * chore: use versioned render in profilerContext test ([hoxyq](https://github.com/hoxyq) in [react#28243](react#28243)) * chore: use versioned render in profilingCommitTreeBuilder test and gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in [react#28236](react#28236)) * chore: use versioned render in profilingHostRoot test and gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in [react#28237](react#28237)) * chore: use versioned render in profilingCache test ([hoxyq](https://github.com/hoxyq) in [react#28242](react#28242)) * chore: use versioned render in ownersListContext test ([hoxyq](https://github.com/hoxyq) in [react#28240](react#28240)) * chore: use versioned render in editing test ([hoxyq](https://github.com/hoxyq) in [react#28239](react#28239)) * chore: use versioned render in treeContext test ([hoxyq](https://github.com/hoxyq) in [react#28245](react#28245)) * chore: use versioned render in store test ([hoxyq](https://github.com/hoxyq) in [react#28244](react#28244)) * chore: use versioned render in profilerStore test ([hoxyq](https://github.com/hoxyq) in [react#28238](react#28238)) * chore: use versioned render in profilingCharts test ([hoxyq](https://github.com/hoxyq) in [react#28235](react#28235)) * chore: use versioned render in profilerChangeDescriptions test ([hoxyq](https://github.com/hoxyq) in [react#28221](react#28221)) * chore: use versioned render in storeOwners test ([hoxyq](https://github.com/hoxyq) in [react#28215](react#28215)) * chore: use versioned render in componentStacks test ([hoxyq](https://github.com/hoxyq) in [react#28214](react#28214)) * chore: use versioned render in console test ([hoxyq](https://github.com/hoxyq) in [react#28213](react#28213)) * chore: use versioned render in useEditableValue test ([hoxyq](https://github.com/hoxyq) in [react#28212](react#28212)) * chore: use versioned render in FastRefreshDevToolsIntegration test ([hoxyq](https://github.com/hoxyq) in [react#28211](react#28211)) * chore: add versioned render implementation for DevTools tests ([hoxyq](https://github.com/hoxyq) in [react#28210](react#28210)) * chore: add single versioned implementation of act for DevTools tests ([hoxyq](https://github.com/hoxyq) in [react#28186](react#28186)) * DevTools: Add support for useFormState ([eps1lon](https://github.com/eps1lon) in [react#28232](react#28232)) * DevTools: Add support for useOptimistic Hook ([eps1lon](https://github.com/eps1lon) in [react#27982](react#27982)) * Add stable React.act export ([acdlite](https://github.com/acdlite) in [react#28160](react#28160)) * [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in [react#27871](react#27871)) * fix[devtools/e2e]: add fallback for act in integration tests ([hoxyq](https://github.com/hoxyq) in [react#27842](react#27842)) * Add stable concurrent option to react-test-renderer ([jackpope](https://github.com/jackpope) in [react#27804](react#27804)) * Update act references in tests ([gnoff](https://github.com/gnoff) in [react#27805](react#27805)) * Flow: make more objects exact ([kassens](https://github.com/kassens) in [react#27790](react#27790))
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
This option was added defensively but it's not needed. There's no cost to including it always. I suspect this optional was added mainly to avoid needing to update tests. That's not a reason to have an unnecessary public API though. We have a praxis for dealing with source location in tests to avoid them failing tests. I also ported them to inline snapshots so that additions to the protocol isn't such a pain. DiffTrain build for commit f0e808e.
Akshato07
pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
Full list of changes (not a public CHANGELOG): * feature[REMOVED][devtools]: turn off / hide location based component filters ([hoxyq](https://github.com/hoxyq) in [#28417](react/react#28417)) * Add useSyncExternalStore and useTransition to getPrimitiveStackCache ([jamesbvaughan](https://github.com/jamesbvaughan) in [#28399](react/react#28399)) * chore[devtools]: use react-window from npm and bump react-virtualized-auto-sizer to ^1.0.23 ([hoxyq](https://github.com/hoxyq) in [#28408](react/react#28408)) * Pass ref as normal prop ([acdlite](https://github.com/acdlite) in [#28348](react/react#28348)) * Combine createElement and JSX modules ([acdlite](https://github.com/acdlite) in [#28320](react/react#28320)) * [Debug Tools] Always use includeHooksSource option ([sebmarkbage](https://github.com/sebmarkbage) in [#28309](react/react#28309)) * Revert "[Tests] Reset modules by default" ([acdlite](https://github.com/acdlite) in [#28318](react/react#28318)) * Switch <Context> to mean <Context.Provider> ([gaearon](https://github.com/gaearon) in [#28226](react/react#28226)) * [Debug Tools] Introspect Promises in use() ([sebmarkbage](https://github.com/sebmarkbage) in [#28297](react/react#28297)) * fix[devtools/useModalDismissSignal]: use getRootNode for shadow root case support ([hoxyq](https://github.com/hoxyq) in [#28145](react/react#28145)) * fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode and synchronous act ([hoxyq](https://github.com/hoxyq) in [#28296](react/react#28296)) * chore: gate legacy apis for react-devtools-shell ([hoxyq](https://github.com/hoxyq) in [#28273](react/react#28273)) * DevTools: Add support for use(Context) ([eps1lon](https://github.com/eps1lon) in [#28233](react/react#28233)) * Remove __self and __source location from elements ([sebmarkbage](https://github.com/sebmarkbage) in [#28265](react/react#28265)) * chore: use versioned render in inspectedElement test ([hoxyq](https://github.com/hoxyq) in [#28246](react/react#28246)) * chore: use versioned render in TimelineProfiler test and gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in [#28218](react/react#28218)) * [Tests] Reset modules by default ([rickhanlonii](https://github.com/rickhanlonii) in [#28254](react/react#28254)) * chore: use versioned render in preprocessData test and gate some for … ([hoxyq](https://github.com/hoxyq) in [#28219](react/react#28219)) * chore: use versioned render in storeStressSync test and gate them for legacy rendering ([hoxyq](https://github.com/hoxyq) in [#28216](react/react#28216)) * Patch devtools before running useMemo function in strict mode ([gsathya](https://github.com/gsathya) in [#28249](react/react#28249)) * chore: use versioned render in storeComponentFilters test ([hoxyq](https://github.com/hoxyq) in [#28241](react/react#28241)) * chore: use versioned render in profilerContext test ([hoxyq](https://github.com/hoxyq) in [#28243](react/react#28243)) * chore: use versioned render in profilingCommitTreeBuilder test and gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in [#28236](react/react#28236)) * chore: use versioned render in profilingHostRoot test and gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in [#28237](react/react#28237)) * chore: use versioned render in profilingCache test ([hoxyq](https://github.com/hoxyq) in [#28242](react/react#28242)) * chore: use versioned render in ownersListContext test ([hoxyq](https://github.com/hoxyq) in [#28240](react/react#28240)) * chore: use versioned render in editing test ([hoxyq](https://github.com/hoxyq) in [#28239](react/react#28239)) * chore: use versioned render in treeContext test ([hoxyq](https://github.com/hoxyq) in [#28245](react/react#28245)) * chore: use versioned render in store test ([hoxyq](https://github.com/hoxyq) in [#28244](react/react#28244)) * chore: use versioned render in profilerStore test ([hoxyq](https://github.com/hoxyq) in [#28238](react/react#28238)) * chore: use versioned render in profilingCharts test ([hoxyq](https://github.com/hoxyq) in [#28235](react/react#28235)) * chore: use versioned render in profilerChangeDescriptions test ([hoxyq](https://github.com/hoxyq) in [#28221](react/react#28221)) * chore: use versioned render in storeOwners test ([hoxyq](https://github.com/hoxyq) in [#28215](react/react#28215)) * chore: use versioned render in componentStacks test ([hoxyq](https://github.com/hoxyq) in [#28214](react/react#28214)) * chore: use versioned render in console test ([hoxyq](https://github.com/hoxyq) in [#28213](react/react#28213)) * chore: use versioned render in useEditableValue test ([hoxyq](https://github.com/hoxyq) in [#28212](react/react#28212)) * chore: use versioned render in FastRefreshDevToolsIntegration test ([hoxyq](https://github.com/hoxyq) in [#28211](react/react#28211)) * chore: add versioned render implementation for DevTools tests ([hoxyq](https://github.com/hoxyq) in [#28210](react/react#28210)) * chore: add single versioned implementation of act for DevTools tests ([hoxyq](https://github.com/hoxyq) in [#28186](react/react#28186)) * DevTools: Add support for useFormState ([eps1lon](https://github.com/eps1lon) in [#28232](react/react#28232)) * DevTools: Add support for useOptimistic Hook ([eps1lon](https://github.com/eps1lon) in [#27982](react/react#27982)) * Add stable React.act export ([acdlite](https://github.com/acdlite) in [#28160](react/react#28160)) * [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in [#27871](react/react#27871)) * fix[devtools/e2e]: add fallback for act in integration tests ([hoxyq](https://github.com/hoxyq) in [#27842](react/react#27842)) * Add stable concurrent option to react-test-renderer ([jackpope](https://github.com/jackpope) in [#27804](react/react#27804)) * Update act references in tests ([gnoff](https://github.com/gnoff) in [#27805](react/react#27805)) * Flow: make more objects exact ([kassens](https://github.com/kassens) in [#27790](react/react#27790)) DiffTrain build for commit react/react@288cf74.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option was added defensively but it's not needed. There's no cost to including it always.
I suspect this optional was added mainly to avoid needing to update tests. That's not a reason to have an unnecessary public API though.
We have a praxis for dealing with source location in tests to avoid them failing tests. I also ported them to inline snapshots so that additions to the protocol isn't such a pain.