Skip to content

[ServerRenderer] Setup for adding data attributes streaming format#25567

Merged
mofeiZ merged 3 commits into
react:mainfrom
mofeiZ:fizz-non-execution-format-setup
Nov 1, 2022
Merged

[ServerRenderer] Setup for adding data attributes streaming format#25567
mofeiZ merged 3 commits into
react:mainfrom
mofeiZ:fizz-non-execution-format-setup

Conversation

@mofeiZ

@mofeiZ mofeiZ commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

Summary

Setup for #25437. This PR does not change any existing behavior, it just adds:

How did you test this change?

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 26, 2022
@sizebot

sizebot commented Oct 26, 2022

Copy link
Copy Markdown

Comparing: fecc288...5f4d560

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 152.69 kB 152.69 kB = 48.70 kB 48.70 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 154.61 kB 154.61 kB = 49.31 kB 49.31 kB
facebook-www/ReactDOM-prod.classic.js = 526.73 kB 526.73 kB = 94.10 kB 94.09 kB
facebook-www/ReactDOM-prod.modern.js = 511.99 kB 511.99 kB = 91.94 kB 91.94 kB
facebook-www/ReactDOMForked-prod.classic.js = 526.73 kB 526.73 kB = 94.10 kB 94.10 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 5f4d560

@mofeiZ mofeiZ marked this pull request as ready for review October 26, 2022 16:04
@mofeiZ mofeiZ changed the title [ServerRenderer][draft] Setup for adding data attributes [ServerRenderer] Setup for adding data attributes streaming format Oct 26, 2022
@mofeiZ mofeiZ force-pushed the fizz-non-execution-format-setup branch from 8e3dc30 to a4662cb Compare October 31, 2022 21:11

@acdlite acdlite left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@mofeiZ mofeiZ merged commit 6883d79 into react:main Nov 1, 2022
GrinZero added a commit to GrinZero/react that referenced this pull request Nov 7, 2022
* 'main' of ssh://github.com/GrinZero/react: (163 commits)
  Do not unmount layout effects if ancestor Offscreen is hidden (react#25628)
  Remove check in renderDidSuspendDelayIfPossible (react#25630)
  [ServerRenderer] Move fizz external runtime implementation to react-dom-bindings (react#25617)
  Unwrap sync resolved thenables without suspending  (react#25615)
  refactor isHostResourceType to not receive the context from reconciler and not leak types (react#25610)
  Make host context use null as empty and only error in dev (react#25609)
  [Float] handle resource Resource creation inside svg context (react#25599)
  Allow uncached IO to stablize (react#25561)
  [ServerRenderer] Setup for adding data attributes streaming format (react#25567)
  Do not unmount layout effects on initial Offscreen mount (react#25592)
  Fix type check for null (react#25595)
  Clean up vestige of useOpaqueIdentifier (react#25587)
  Extract logic for detecting bad fallback to helper
  Split suspended work loop logic into separate functions
  In work loop, add enum of reasons for suspending
  Strict Mode: Reuse memoized result from first pass (react#25583)
  Detect and warn if use(promise) is wrapped with try/catch block (react#25543)
  Remove old react-fetch, react-fs and react-pg libraries (react#25577)
  Try assigning fetch to globalThis if global assignment fails (react#25571)
  [Float] handle noscript context for Resources (react#25559)
  ...

# Conflicts:
#	scripts/rollup/build.js
facebook-github-bot pushed a commit to react/react-native that referenced this pull request Nov 7, 2022
Summary:
This sync includes the following changes:
- **[4bd245e](react/react@4bd245e9e )**: Do not unmount layout effects if ancestor Offscreen is hidden ([#25628](react/react#25628)) //<Samuel Susla>//
- **[df61e70](react/react@df61e708c )**: Remove check in renderDidSuspendDelayIfPossible ([#25630](react/react#25630)) //<Andrew Clark>//
- **[1a08f14](react/react@1a08f1478 )**: [ServerRenderer] Move fizz external runtime implementation to react-dom-bindings ([#25617](react/react#25617)) //<mofeiZ>//
- **[1a90262](react/react@1a902623a )**: Unwrap sync resolved thenables without suspending  ([#25615](react/react#25615)) //<Andrew Clark>//
- **[4ea063b](react/react@4ea063b56 )**: refactor isHostResourceType to not receive the context from reconciler and not leak types ([#25610](react/react#25610)) //<Josh Story>//
- **[8e69bc4](react/react@8e69bc45a )**: Make host context use null as empty and only error in dev ([#25609](react/react#25609)) //<Sebastian Markbåge>//
- **[5f7ef8c](react/react@5f7ef8c4c )**: [Float] handle resource Resource creation inside svg context ([#25599](react/react#25599)) //<Josh Story>//
- **[36426e6](react/react@36426e6cb )**: Allow uncached IO to stablize ([#25561](react/react#25561)) //<Andrew Clark>//
- **[6883d79](react/react@6883d7944 )**: [ServerRenderer] Setup for adding data attributes streaming format ([#25567](react/react#25567)) //<mofeiZ>//

Changelog:
[General][Changed] - React Native sync for revisions ab075a2...4bd245e

jest_e2e[run_all_tests]

Reviewed By: GijsWeterings

Differential Revision: D41028209

fbshipit-source-id: a67fdcd441ddd50784f7c1ce402eaecdb5e3126d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants