Skip to content

[Transition Tracing] Create/Process Marker Complete Callback#24700

Merged
lunaruan merged 2 commits into
react:mainfrom
lunaruan:add_marker_complete
Jun 13, 2022
Merged

[Transition Tracing] Create/Process Marker Complete Callback#24700
lunaruan merged 2 commits into
react:mainfrom
lunaruan:add_marker_complete

Conversation

@lunaruan

@lunaruan lunaruan commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

This PR adds code to add a marker complete callback to the queue. It also adds code to process marker complete callback.

Marker complete callbacks, in addition to the fields that transition complete callbacks need, also have a markerName field

@lunaruan lunaruan requested a review from acdlite June 10, 2022 00:18
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 10, 2022
@lunaruan lunaruan force-pushed the add_marker_complete branch from 6658634 to 9c3315b Compare June 10, 2022 00:19
@sizebot

sizebot commented Jun 10, 2022 •
edited
Loading

Copy link
Copy Markdown

Comparing: a8555c3...7cd41cc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.78 kB 131.78 kB = 42.31 kB 42.31 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 137.05 kB 137.05 kB = 43.90 kB 43.90 kB
facebook-www/ReactDOM-prod.classic.js = 441.11 kB 441.11 kB = 80.68 kB 80.68 kB
facebook-www/ReactDOM-prod.modern.js = 426.42 kB 426.42 kB = 78.49 kB 78.49 kB
facebook-www/ReactDOMForked-prod.classic.js = 441.82 kB 441.82 kB = 80.90 kB 80.90 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 7cd41cc

acdlite
acdlite reviewed Jun 13, 2022
View reviewed changes
Comment thread packages/react-reconciler/src/ReactFiberWorkLoop.old.js Outdated
}
}

if (currentPendingTransitionCallbacks.markerComplete === null) {

@acdlite acdlite Jun 13, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Put this code inside the flag check

@lunaruan lunaruan force-pushed the add_marker_complete branch from 9c3315b to 7cd41cc Compare June 13, 2022 17:26
@lunaruan lunaruan merged commit 7cf8dfd into react:main Jun 13, 2022
facebook-github-bot pushed a commit to react/react-native that referenced this pull request Jun 15, 2022
@rickhanlonii @facebook-github-bot
React Native sync for revisions d300ceb...256aefb
d1321d8 
Summary:
This sync includes the following changes:
- **[5cc2487](react/react@5cc2487e0 )**: bump versions for next release ([#24725](react/react#24725)) //<Josh Story>//
- **[54f17e4](react/react@54f17e490 )**: [Transition Tracing] Fix Cache and Transitions Pop Order ([#24719](react/react#24719)) //<Luna Ruan>//
- **[7cf8dfd](react/react@7cf8dfd94 )**: [Transition Tracing] Create/Process Marker Complete Callback ([#24700](react/react#24700)) //<Luna Ruan>//
- **[327e4a1](react/react@327e4a1f9 )**: [Follow-up] Land enableClientRenderFallbackOnTextMismatch //<Andrew Clark>//
- **[a8c9cb1](react/react@a8c9cb18b )**: Land enableSuspenseLayoutEffectSemantics flag ([#24713](react/react#24713)) //<Andrew Clark>//
- **[a8555c3](react/react@a8555c308 )**: [Transition Tracing] Add Tracing Marker Stack ([#24661](react/react#24661)) //<Luna Ruan>//
- **[8186b19](react/react@8186b1937 )**: Check for infinite update loops even if unmounted ([#24697](react/react#24697)) //<Andrew Clark>//
- **[060505e](react/react@060505e9d )**: Fix misapplying prod error opt-out ([#24688](react/react#24688)) //<Josh Story>//
- **[4794414](react/react@47944142f )**: `now` isn't part of the react-reconciler config anymore ([#24689](react/react#24689)) //<Mathieu Dutour>//
- **[b345523](react/react@b34552352 )**: [Fizz] Support abort reasons ([#24680](react/react#24680)) //<Josh Story>//
- **[79f54c1](react/react@79f54c16d )**: Bugfix: Revealing a hidden update ([#24685](react/react#24685)) //<Andrew Clark>//
- **[7e8a020](react/react@7e8a020a4 )**: Remove extra Server Context argument ([#24683](react/react#24683)) //<Sebastian Markbåge>//
- **[4f29ba1](react/react@4f29ba1cc )**: support errorInfo in onRecoverableError ([#24591](react/react#24591)) //<Josh Story>//
- **[1cd90d2](react/react@1cd90d2cc )**: Refactor of interleaved ("concurrent") update queue ([#24663](react/react#24663)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions d300ceb...256aefb

jest_e2e[run_all_tests]

Reviewed By: cortinico

Differential Revision: D37155957

fbshipit-source-id: 4c0afc95abe8fa13c3803584922c8dc0059ff562
facebook-github-bot pushed a commit to react/react-native that referenced this pull request Aug 17, 2022
@sammy-SC @facebook-github-bot
React Native sync for revisions a8c9cb1...256aefb
ba383ba 
Summary:
This sync includes the following changes:
- **[229c86a](react/react@229c86af0 )**: Revert "Land enableClientRenderFallbackOnTextMismatch" ([#24738](react/react#24738)) //<Andrew Clark>//
- **[c3d7a7e](react/react@c3d7a7e3d )**: Bugfix: Offscreen instance is null during setState ([#24734](react/react#24734)) //<Andrew Clark>//
- **[fcd720d](react/react@fcd720d36 )**: [Transition Tracing] Push Transition When Offscreen Becomes Visible ([#24718](react/react#24718)) //<Luna Ruan>//
- **[5cc2487](react/react@5cc2487e0 )**: bump versions for next release ([#24725](react/react#24725)) //<Josh Story>//
- **[54f17e4](react/react@54f17e490 )**: [Transition Tracing] Fix Cache and Transitions Pop Order ([#24719](react/react#24719)) //<Luna Ruan>//
- **[7cf8dfd](react/react@7cf8dfd94 )**: [Transition Tracing] Create/Process Marker Complete Callback ([#24700](react/react#24700)) //<Luna Ruan>//
- **[327e4a1](react/react@327e4a1f9 )**: [Follow-up] Land enableClientRenderFallbackOnTextMismatch //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions a8c9cb1...229c86a

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D38738652

fbshipit-source-id: 35b6b3cbfdbdafc28a356b53af6456aaa1949432
roryabraham pushed a commit to Expensify/react-native that referenced this pull request Aug 17, 2022
@sammy-SC @roryabraham
React Native sync for revisions a8c9cb1...256aefb
c1a614f 
Summary:
This sync includes the following changes:
- **[229c86a](react/react@229c86af0 )**: Revert "Land enableClientRenderFallbackOnTextMismatch" ([react#24738](react/react#24738)) //<Andrew Clark>//
- **[c3d7a7e](react/react@c3d7a7e3d )**: Bugfix: Offscreen instance is null during setState ([react#24734](react/react#24734)) //<Andrew Clark>//
- **[fcd720d](react/react@fcd720d36 )**: [Transition Tracing] Push Transition When Offscreen Becomes Visible ([react#24718](react/react#24718)) //<Luna Ruan>//
- **[5cc2487](react/react@5cc2487e0 )**: bump versions for next release ([react#24725](react/react#24725)) //<Josh Story>//
- **[54f17e4](react/react@54f17e490 )**: [Transition Tracing] Fix Cache and Transitions Pop Order ([react#24719](react/react#24719)) //<Luna Ruan>//
- **[7cf8dfd](react/react@7cf8dfd94 )**: [Transition Tracing] Create/Process Marker Complete Callback ([react#24700](react/react#24700)) //<Luna Ruan>//
- **[327e4a1](react/react@327e4a1f9 )**: [Follow-up] Land enableClientRenderFallbackOnTextMismatch //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions a8c9cb1...229c86a

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D38738652

fbshipit-source-id: 35b6b3cbfdbdafc28a356b53af6456aaa1949432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acdlite acdlite acdlite approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lunaruan @sizebot @acdlite @facebook-github-bot