Remove @flow pragma comment from module registration start/stop templates#22670
Merged
Conversation
|
Comparing: a0d991f...484bf0c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
bvaughn
commented
Nov 1, 2021
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @flow |
Contributor
Author
There was a problem hiding this comment.
I guess it doesn't really matter that we'll "lose" Flow coverage on these files anyway b'c the DevTools hook doesn't have strong Flow types.
…ates This results in a duplicate @flow pragma in built bundles, which breaks xplat CI.
jstejada
approved these changes
Nov 1, 2021
Contributor
|
@bvaughn with this it still copies over the copyright header and "// Don't require this file directly; it's embedded by Rollup during build." comment. Can we remove those too? |
Contributor
Author
|
Do you have a suggestion to remove them? I think the files in the source should be clear: They aren't intended for direct use. Putting them in source though lets us get free ESLint coverage at least (if not Flow). I'd like to avoid hard-coding strings (or string ranges) in our Rollup build script. |
Contributor
|
I don't know how to do it correctly, I just know what the result is. Any idea why this doesn't happen in ReactDOM? |
Contributor
Author
|
It does. https://unpkg.com/browse/react-dom@18.0.0-alpha-ebf9ae857-20211101/cjs/react-dom.development.js IMO it's not ideal but it's not that big of a deal either. Definitely open for suggestions on ways to improve it though, but in the meanwhile let's land this to unblock the sync? Edit: #22673 |
facebook-github-bot
pushed a commit
to react/react-native
that referenced
this pull request
Nov 2, 2021
Summary: This sync includes the following changes: - **[5cccacd](react/react@5cccacd13 )**: Upgrade useId to alpha channel ([#22674](react/react#22674)) //<Andrew Clark>// - **[75f3dde](react/react@75f3ddebf )**: Remove experimental useOpaqueIdentifier API ([#22672](react/react#22672)) //<Andrew Clark>// - **[8c4a05b](react/react@8c4a05b8f )**: Remove flow pragma comment from module registration start/stop templates ([#22670](react/react#22670)) //<Brian Vaughn>// - **[ebf9ae8](react/react@ebf9ae857 )**: useId ([#22644](react/react#22644)) //<Andrew Clark>// - **[a0d991f](react/react@a0d991fe6 )**: Re-land #22292 (remove uMS from open source build) ([#22664](react/react#22664)) //<Andrew Clark>// - **[6bce035](react/react@6bce0355c )**: Upgrade useSyncExternalStore to alpha channel ([#22662](react/react#22662)) //<Andrew Clark>// - **[7034408](react/react@7034408ff )**: Follow-up improvements to error code extraction infra ([#22516](react/react#22516)) //<Andrew Clark>// - **[90e5d36](react/react@90e5d3638 )**: chore: fix comment typo ([#22615](react/react#22615)) //<btea>// - **[3c4c1c4](react/react@3c4c1c470 )**: Remove warning for dangling passive effects ([#22609](react/react#22609)) //<Andrew Clark>// - **[d5b6b4b](react/react@d5b6b4b86 )**: Expand act warning to cover all APIs that might schedule React work ([#22607](react/react#22607)) //<Andrew Clark>// - **[fa9bea0](react/react@fa9bea0c4 )**: Initial implementation of cache cleanup ([#22510](react/react#22510)) //<Joseph Savona>// - **[0e8a5af](react/react@0e8a5aff3 )**: Scheduling Profiler: Add marks for component effects (mount and unmount) ([#22578](react/react#22578)) //<Brian Vaughn>// - **[4ba2057](react/react@4ba20579d )**: Scheduling Profiler: De-emphasize React internal frames ([#22588](react/react#22588)) //<Brian Vaughn>// - **[cdb8a1d](react/react@cdb8a1d19 )**: [Fizz] Add option to inject bootstrapping script tags after the shell is injected ([#22594](react/react#22594)) //<Sebastian Markbåge>// - **[34e4c97](react/react@34e4c9756 )**: Clear extra nodes if there's a hydration mismatch within a suspense boundary ([#22592](react/react#22592)) //<Sebastian Markbåge>// - **[02f4115](react/react@02f411578 )**: Upgrade useInsertionEffect to stable ([#22589](react/react#22589)) //<Andrew Clark>// - **[2af4a79](react/react@2af4a7933 )**: Hydrate using SuspenseComponent as the parent ([#22582](react/react#22582)) //<Sebastian Markbåge>// - **[b1acff0](react/react@b1acff0cc )**: Enable cache in test renderer ([#22580](react/react#22580)) //<Joseph Savona>// - **[996da67](react/react@996da67b2 )**: Replace global `jest` heuristic with `IS_REACT_ACT_ENVIRONMENT` ([#22562](react/react#22562)) //<Andrew Clark>// - **[163e81c](react/react@163e81c1f )**: Support disabling spurious act warnings with a global environment flag ([#22561](react/react#22561)) //<Andrew Clark>// - **[23b7dfe](react/react@23b7dfeff )**: Enable scheduling profiler for RN FB profiling builds ([#22566](react/react#22566)) //<Brian Vaughn>// - **[61455a2](react/react@61455a25b )**: Enable experimental Cache API in www TestRenderer ([#22554](react/react#22554)) //<Joseph Savona>// - **[7142d11](react/react@7142d110b )**: Bugfix: Nested useOpaqueIdentifier references ([#22553](react/react#22553)) //<Andrew Clark>// - **[1e247ff](react/react@1e247ff89 )**: Enabled scheduling profiler marks for React Native FB target ([#22544](react/react#22544)) //<Brian Vaughn>// - **[c16b005](react/react@c16b005f2 )**: Update test and stack frame code to support newer V8 stack formats ([#22477](react/react#22477)) //<Brian Vaughn>// - **[55d7500](react/react@55d75005b )**: duplicate value in variable ([#22390](react/react#22390)) //<BIKI DAS>// Changelog: [General][Changed] - React Native sync for revisions afcb9cd...3fcd81d jest_e2e[run_all_tests] Reviewed By: yungsters Differential Revision: D32065987 fbshipit-source-id: ef2d402835c981aab68ca40a894c66c1630864e9
KamranAsif
pushed a commit
to KamranAsif/react
that referenced
this pull request
Nov 4, 2021
facebook-github-bot
pushed a commit
to react/react-native
that referenced
this pull request
Nov 15, 2021
Summary: This sync includes the following changes: - **[c0c71a8](react/react@c0c71a868 )**: Re-enable useMutableSource in internal RN ([#22750](react/react#22750)) //<Ricky>// - **[cb11155](react/react@cb11155c8 )**: Add runtime type checks around module boundary code ([#22748](react/react#22748)) //<Brian Vaughn>// - **[a04f13d](react/react@a04f13d29 )**: react-refresh@0.11.0 //<Dan Abramov>// - **[ff9897d](react/react@ff9897d23 )**: [React Refresh] support typescript namespace syntax ([#22621](react/react#22621)) //<irinakk>// - **[0ddd69d](react/react@0ddd69d12 )**: Throw on hydration mismatch and force client rendering if boundary hasn't suspended within concurrent root ([#22629](react/react#22629)) //<salazarm>// - **[c3f34e4](react/react@c3f34e4be )**: eslint-plugin-react-hooks@4.3.0 //<Dan Abramov>// - **[827021c](react/react@827021c4e )**: Changelog for eslint-plugin-react-hooks@4.3.0 //<Dan Abramov>// - **[8ca3f56](react/react@8ca3f567b )**: Fix module-boundary wrappers ([#22688](react/react#22688)) //<Brian Vaughn>// - **[1bf6deb](react/react@1bf6deb86 )**: Renamed packages/react-devtools-scheduling-profiler to packages/react-devtools-timeline ([#22691](react/react#22691)) //<Brian Vaughn>// - **[51c558a](react/react@51c558aeb )**: Rename (some) "scheduling profiler" references to "timeline" ([#22690](react/react#22690)) //<Brian Vaughn>// - **[00ced1e](react/react@00ced1e2b )**: Fix useId in strict mode ([#22681](react/react#22681)) //<Andrew Clark>// - **[5cccacd](react/react@5cccacd13 )**: Upgrade useId to alpha channel ([#22674](react/react#22674)) //<Andrew Clark>// - **[75f3dde](react/react@75f3ddebf )**: Remove experimental useOpaqueIdentifier API ([#22672](react/react#22672)) //<Andrew Clark>// - **[8c4a05b](react/react@8c4a05b8f )**: Remove flow pragma comment from module registration start/stop templates ([#22670](react/react#22670)) //<Brian Vaughn>// - **[ebf9ae8](react/react@ebf9ae857 )**: useId ([#22644](react/react#22644)) //<Andrew Clark>// - **[a0d991f](react/react@a0d991fe6 )**: Re-land #22292 (remove uMS from open source build) ([#22664](react/react#22664)) //<Andrew Clark>// - **[6bce035](react/react@6bce0355c )**: Upgrade useSyncExternalStore to alpha channel ([#22662](react/react#22662)) //<Andrew Clark>// - **[7034408](react/react@7034408ff )**: Follow-up improvements to error code extraction infra ([#22516](react/react#22516)) //<Andrew Clark>// - **[90e5d36](react/react@90e5d3638 )**: chore: fix comment typo ([#22615](react/react#22615)) //<btea>// - **[3c4c1c4](react/react@3c4c1c470 )**: Remove warning for dangling passive effects ([#22609](react/react#22609)) //<Andrew Clark>// - **[d5b6b4b](react/react@d5b6b4b86 )**: Expand act warning to cover all APIs that might schedule React work ([#22607](react/react#22607)) //<Andrew Clark>// - **[fa9bea0](react/react@fa9bea0c4 )**: Initial implementation of cache cleanup ([#22510](react/react#22510)) //<Joseph Savona>// - **[0e8a5af](react/react@0e8a5aff3 )**: Scheduling Profiler: Add marks for component effects (mount and unmount) ([#22578](react/react#22578)) //<Brian Vaughn>// - **[4ba2057](react/react@4ba20579d )**: Scheduling Profiler: De-emphasize React internal frames ([#22588](react/react#22588)) //<Brian Vaughn>// - **[cdb8a1d](react/react@cdb8a1d19 )**: [Fizz] Add option to inject bootstrapping script tags after the shell is injected ([#22594](react/react#22594)) //<Sebastian Markbåge>// - **[34e4c97](react/react@34e4c9756 )**: Clear extra nodes if there's a hydration mismatch within a suspense boundary ([#22592](react/react#22592)) //<Sebastian Markbåge>// - **[02f4115](react/react@02f411578 )**: Upgrade useInsertionEffect to stable ([#22589](react/react#22589)) //<Andrew Clark>// - **[2af4a79](react/react@2af4a7933 )**: Hydrate using SuspenseComponent as the parent ([#22582](react/react#22582)) //<Sebastian Markbåge>// - **[b1acff0](react/react@b1acff0cc )**: Enable cache in test renderer ([#22580](react/react#22580)) //<Joseph Savona>// - **[996da67](react/react@996da67b2 )**: Replace global `jest` heuristic with `IS_REACT_ACT_ENVIRONMENT` ([#22562](react/react#22562)) //<Andrew Clark>// - **[163e81c](react/react@163e81c1f )**: Support disabling spurious act warnings with a global environment flag ([#22561](react/react#22561)) //<Andrew Clark>// - **[23b7dfe](react/react@23b7dfeff )**: Enable scheduling profiler for RN FB profiling builds ([#22566](react/react#22566)) //<Brian Vaughn>// - **[61455a2](react/react@61455a25b )**: Enable experimental Cache API in www TestRenderer ([#22554](react/react#22554)) //<Joseph Savona>// - **[7142d11](react/react@7142d110b )**: Bugfix: Nested useOpaqueIdentifier references ([#22553](react/react#22553)) //<Andrew Clark>// - **[1e247ff](react/react@1e247ff89 )**: Enabled scheduling profiler marks for React Native FB target ([#22544](react/react#22544)) //<Brian Vaughn>// - **[c16b005](react/react@c16b005f2 )**: Update test and stack frame code to support newer V8 stack formats ([#22477](react/react#22477)) //<Brian Vaughn>// - **[55d7500](react/react@55d75005b )**: duplicate value in variable ([#22390](react/react#22390)) //<BIKI DAS>// Changelog: [General][Changed] - React Native sync for revisions afcb9cd...c0c71a8 jest_e2e[run_all_tests] Reviewed By: yungsters Differential Revision: D32395873 fbshipit-source-id: 3afd158f167b1eedcc244e29aba1a2c502d3c9d9
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This results in a duplicate
@flowpragma in built bundles, which breaks xplat CI.