Skip to content

Make enableSuspenseLayoutEffectSemantics static for www#21617

Merged
bvaughn merged 1 commit into
react:masterfrom
bvaughn:enableSuspenseLayoutEffectSemantics
Jun 3, 2021
Merged

Make enableSuspenseLayoutEffectSemantics static for www#21617
bvaughn merged 1 commit into
react:masterfrom
bvaughn:enableSuspenseLayoutEffectSemantics

Conversation

@bvaughn

@bvaughn bvaughn commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

This feature is now enabled for the OSS release and the GK has been ramped up to 80% within FB (so the next step is to make it a static flag there as well).

This has been ramped up to 80% GK so the next step is to just turn it on for 100%
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 3, 2021
@sizebot

sizebot commented Jun 3, 2021

Copy link
Copy Markdown

Comparing: 7747a56...395c5e0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.29 kB 127.29 kB = 40.81 kB 40.81 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.11 kB 130.11 kB = 41.75 kB 41.75 kB
facebook-www/ReactDOM-prod.classic.js = 406.00 kB 404.72 kB = 75.07 kB 74.90 kB
facebook-www/ReactDOM-prod.modern.js = 394.35 kB 393.27 kB = 73.25 kB 73.09 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.00 kB 404.72 kB = 75.07 kB 74.90 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/JSXDEVRuntime-dev.classic.js = 42.12 kB 42.02 kB = 11.77 kB 11.74 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 42.12 kB 42.02 kB = 11.77 kB 11.74 kB
facebook-www/ReactDOM-profiling.modern.js = 419.34 kB 418.25 kB = 77.53 kB 77.38 kB
facebook-www/ReactDOMForked-profiling.modern.js = 419.34 kB 418.25 kB = 77.53 kB 77.38 kB
facebook-www/ReactDOM-prod.modern.js = 394.35 kB 393.27 kB = 73.25 kB 73.09 kB
facebook-www/ReactDOMForked-prod.modern.js = 394.35 kB 393.27 kB = 73.25 kB 73.09 kB
facebook-www/ReactDOM-profiling.classic.js = 431.02 kB 429.73 kB = 79.29 kB 79.12 kB
facebook-www/ReactDOMForked-profiling.classic.js = 431.02 kB 429.73 kB = 79.29 kB 79.12 kB
facebook-www/ReactDOM-prod.classic.js = 406.00 kB 404.72 kB = 75.07 kB 74.90 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.00 kB 404.72 kB = 75.07 kB 74.90 kB
facebook-www/ReactART-prod.modern.js = 255.35 kB 254.27 kB = 45.37 kB 45.24 kB
facebook-www/ReactART-prod.classic.js = 262.91 kB 261.62 kB = 46.66 kB 46.50 kB
facebook-www/ReactIs-dev.classic.js = 10.05 kB 9.95 kB = 2.68 kB 2.66 kB
facebook-www/ReactIs-dev.modern.js = 10.05 kB 9.95 kB = 2.68 kB 2.66 kB

Generated by 🚫 dangerJS against 395c5e0

@bvaughn bvaughn merged commit 39f0074 into react:master Jun 3, 2021
@bvaughn bvaughn deleted the enableSuspenseLayoutEffectSemantics branch June 3, 2021 19:41
facebook-github-bot pushed a commit to react/react-native that referenced this pull request Jun 7, 2021
Summary:
- **[0eea577](react/react@0eea57724 )**: Fix typo in comment (accumlated → accumulated) ([#21637](react/react#21637)) //<ithinker5>//
- **[0706162](react/react@0706162ba )**: Fix typo in comment (environement → environment) ([#21635](react/react#21635)) //<niexq>//
- **[9d17b56](react/react@9d17b562b )**: Fix typo in comment (satsify → satisfy) ([#21629](react/react#21629)) //<niexq>//
- **[b610fec](react/react@b610fec00 )**: fix comments: expiration time -> lanes ([#21551](react/react#21551)) //<Shannon Feng>//
- **[cc4d24a](react/react@cc4d24ab0 )**: [Fizz] Always call flush() if it exists ([#21625](react/react#21625)) //<Dan Abramov>//
- **[e0d9b28](react/react@e0d9b2899 )**: [Fizz] Minor Fixes for Warning Parity ([#21618](react/react#21618)) //<Sebastian Markbåge>//
- **[1b7b359](react/react@1b7b3592f )**: [Fizz] Implement Component Stacks in DEV for warnings ([#21610](react/react#21610)) //<Sebastian Markbåge>//
- **[39f0074](react/react@39f007489 )**: Make enableSuspenseLayoutEffectSemantics static for www ([#21617](react/react#21617)) //<Brian Vaughn>//
- **[8f37942](react/react@8f3794276 )**: Prepare semver (`latest`) releases in CI ([#21615](react/react#21615)) //<Andrew Clark>//
- **[8b42015](react/react@8b4201535 )**: Devtools: add feature to trigger an error boundary ([#21583](react/react#21583)) //<Bao Pham>//
- **[154a8cf](react/react@154a8cf32 )**: Fix reference to wrong variable //<Andrew Clark>//
- **[6736a38](react/react@6736a38b9 )**: Add single source of truth for package versions ([#21608](react/react#21608)) //<Andrew Clark>//
- **[86715ef](react/react@86715efa2 )**: Resolve the true entry point during tests ([#21505](react/react#21505)) //<Sebastian Markbåge>//
- **[a8a4742](react/react@a8a4742f1 )**: Convert ES6/TypeScript/CoffeeScript Tests to createRoot + act ([#21598](react/react#21598)) //<Sebastian Markbåge>//
- **[1d35589](react/react@1d3558965 )**: Disable deferRenderPhaseUpdateToNextBatch by default ([#21605](react/react#21605)) //<Sebastian Markbåge>//
- **[a896464](react/react@a8964649b )**: Delete an unused field ([#21415](react/react#21415)) //<okmttdhr>//
- **[76f85b3](react/react@76f85b3e5 )**: Expose Fizz in stable builds ([#21602](react/react#21602)) //<Dan Abramov>//
- **[e16d61c](react/react@e16d61c30 )**: [Offscreen] Mount/unmount layout effects ([#21386](react/react#21386)) //<Andrew Clark>//
- **[6309193](react/react@63091939b )**: OSS feature flag updates ([#21597](react/react#21597)) //<Brian Vaughn>//
- **[efbd69b](react/react@efbd69b27 )**:  Define global __WWW__ = true flag during www tests ([#21504](react/react#21504)) //<Sebastian Markbåge>//
- **[28625c6](react/react@28625c6f4 )**: Disable strict effects for legacy roots (again) ([#21591](react/react#21591)) //<Brian Vaughn>//
- **[3c23414](react/react@3c2341416 )**: Update jest to v26 ([#21574](react/react#21574)) //<Sebastian Silbermann>//
- **[0d493dc](react/react@0d493dcda )**: Removed _debugID field from Fiber - Issue #21558 ([#21570](react/react#21570)) //<Pulkit Sharma>//
- **[7841d06](react/react@7841d0695 )**: Enable the updater-tracking feature flag in more builds ([#21567](react/react#21567)) //<Brian Vaughn>//
- **[6405efc](react/react@6405efc36 )**: Enabled Profiling feature flags for OSS release ([#21565](react/react#21565)) //<Brian Vaughn>//

Changelog:
[General][Changed] - React Native sync for revisions 2d8d133...0eea577

jest_e2e[run_all_tests]

Reviewed By: bvaughn

Differential Revision: D28932083

fbshipit-source-id: 012c1bfb857ed59d7283334d633f1cce8ec50360
sebmarkbage added a commit to sebmarkbage/react that referenced this pull request Jun 10, 2021
sebmarkbage added a commit that referenced this pull request Jun 10, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
This has been ramped up to 80% GK so the next step is to just turn it on for 100%
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
facebook-github-bot pushed a commit to react/react-native that referenced this pull request Jun 22, 2021
Summary:
This sync includes the following changes:
- **[43f4cc1](react/react@43f4cc160 )**: Fix failing test ([#21697](react/react#21697)) //<Dan Abramov>//
- **[d0f348d](react/react@d0f348dc1 )**: Fix for failed Suspense layout semantics ([#21694](react/react#21694)) //<Brian Vaughn>//
- **[bd0a963](react/react@bd0a96344 )**: Throw when `act` is used in production ([#21686](react/react#21686)) //<Andrew Clark>//
- **[9343f87](react/react@9343f8720 )**: Use the server src files as entry points for the builds/tests ([#21683](react/react#21683)) //<Sebastian Markbåge>//
- **[502f8a2](react/react@502f8a2a0 )**: [Fizz/Flight] Don't use default args ([#21681](react/react#21681)) //<Sebastian Markbåge>//
- **[a8f5e77](react/react@a8f5e77b9 )**: Remove invokeGuardedCallback from commit phase ([#21666](react/react#21666)) //<Dan Abramov>//
- **[dbe3363](react/react@dbe3363cc )**: [Fizz] Implement Legacy renderToString and renderToNodeStream on top of Fizz ([#21276](react/react#21276)) //<Sebastian Markbåge>//
- **[101ea9f](react/react@101ea9f55 )**: Set deletedTreeCleanUpLevel to 3 ([#21679](react/react#21679)) //<Dan Abramov>//
- **[1a106bd](react/react@1a106bdc2 )**: Wrap eventhandle-specific logic in a flag ([#21657](react/react#21657)) //<Dan Abramov>//
- **[cb30388](react/react@cb30388d1 )**: Export React Native `AttributeType` Types ([#21661](react/react#21661)) //<Timothy Yung>//
- **[c153679](react/react@c1536795c )**: Revert "Make enableSuspenseLayoutEffectSemantics static for www ([#21617](react/react#21617))" ([#21656](react/react#21656)) //<Sebastian Markbåge>//

Changelog:
[General][Changed] - React Native sync for revisions c96b78e...568dc35

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D29303157

fbshipit-source-id: 90952885eb2264f4effa04070357b80700bb9be3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants