[Fizz] Add FB specific streaming API and build#21337
Merged
Merged
Conversation
|
Comparing: c3cb2c2...05075f7 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
gaearon
approved these changes
Apr 22, 2021
facebook-github-bot
pushed a commit
to react/react-native
that referenced
this pull request
Apr 28, 2021
Summary: This sync includes the following changes: - **[9a25916](react/react@9a2591681 )**: Fix export //<Sebastian Markbage>// - **[4a8deb0](react/react@4a8deb083 )**: Switch the isPrimaryRender flag based on the stream config ([#21357](react/react#21357)) //<Sebastian Markbåge>// - **[bd4f056](react/react@bd4f056a3 )**: [Fizz] Implement lazy components and nodes ([#21355](react/react#21355)) //<Sebastian Markbåge>// - **[fc33f12](react/react@fc33f12bd )**: Remove unstable scheduler/tracing API ([#20037](react/react#20037)) //<Brian Vaughn>// - **[7212383](react/react@721238394 )**: Enable strict effects mode for React Native Facebook builds ([#21354](react/react#21354)) //<Brian Vaughn>// - **[4874042](react/react@48740429b )**: Expiration: Do nothing except disable time slicing ([#21345](react/react#21345)) //<Andrew Clark>// - **[0f5ebf3](react/react@0f5ebf366 )**: Delete unreferenced type ([#21343](react/react#21343)) //<Andrew Clark>// - **[9cd52b2](react/react@9cd52b27f )**: Restore context after an error happens ([#21341](react/react#21341)) //<Sebastian Markbåge>// - **[ad09175](react/react@ad091759a )**: Revert "Emit reactroot attribute on the first element we discover ([#21154](react/react#21154))" ([#21340](react/react#21340)) //<Sebastian Markbåge>// - **[709f948](react/react@709f94841 )**: [Fizz] Add FB specific streaming API and build ([#21337](react/react#21337)) //<Sebastian Markbåge>// - **[e8cdce4](react/react@e8cdce40d )**: Don't flush sync at end of discreteUpdates ([#21327](react/react#21327)) //<Andrew Clark>// - **[a155860](react/react@a15586001 )**: Fix: Don't flush discrete at end of batchedUpdates ([#21229](react/react#21229)) //<Andrew Clark>// - **[89847bf](react/react@89847bf6e )**: Continuous updates should interrupt transitions ([#21323](react/react#21323)) //<Andrew Clark>// - **[ef37d55](react/react@ef37d55b6 )**: Use performConcurrentWorkOnRoot for "sync default" ([#21322](react/react#21322)) //<Andrew Clark>// Changelog: [General][Changed] - React Native sync for revisions a632f7d...2a7bb41 jest_e2e[run_all_tests] Reviewed By: JoshuaGross Differential Revision: D28063006 fbshipit-source-id: 7e3535f80961706863b6c2188ee44b5796b2f000
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
Add FB specific streaming API and build
Contributor
|
I wonder how this PR was able to land given that The build script also throws if there's no Are we filtering out private packages somewhere? |
Contributor
Author
|
Seems we don’t get there if there wasn’t a node_modules built which there wouldn’t be for FB-only builds. Like if there’s no NODE_PROD. |
Contributor
|
Hm. When I build all packages locally, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have either Browser nor Node streams at FB WWW. This adds a specific ServerStreamConfig and exported API for this purpose. It's not necessarily optimal. E.g. this doesn't take advantage of back pressure, sharing buffers with the underlying sink and doesn't support TypedArrays. It's just closest to what we already have but we can iterate on this independently.
We also happen to import React with custom builds instead of npm. So I build it separately without an entry point.
It's kinds of similar to what we do with Flight for Relay so I just added it under that folder and it's flow typed under the "dom-relay" flag to avoid having too many Flow passes.
I made a new build that builds to ReactDOMServer.js but only in EXPERIMENTAL which is actually "modern" builds. So the net effect will be that ReactDOMServer.modern.js is Fizz.
I plan on moving Fizz onto the main
react-dom/serverexport but it's difficult because we need it to export multiple builds which goes against the grain of our system atm. But the idea is to export both and then remove legacy. So this is just jumping ahead to the last step for FB.This structure probably doesn't make much sense overall but it is what it is.