Skip to content

Add passing exhaustive-deps test for type parameters in TypeScript#20432

Merged
eps1lon merged 1 commit into
react:mainfrom
eps1lon:test/exhaustive-deps-generic-args
Mar 14, 2024
Merged

Add passing exhaustive-deps test for type parameters in TypeScript#20432
eps1lon merged 1 commit into
react:mainfrom
eps1lon:test/exhaustive-deps-generic-args

Conversation

@eps1lon

@eps1lon eps1lon commented Dec 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Adds a test for #20395

Test Plan

  • CI green

@eps1lon eps1lon mentioned this pull request Dec 11, 2020
Closed
@codesandbox-ci

codesandbox-ci Bot commented Dec 11, 2020

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 639b21f:

Sandbox Source
React Configuration

@sizebot

sizebot commented Dec 11, 2020

Copy link
Copy Markdown
Warnings
⚠️ Build job for base commit is still pending: cdfde3a

Size changes (experimental)

Generated by 🚫 dangerJS against 639b21f

@sizebot

sizebot commented Dec 11, 2020 •
edited
Loading

Copy link
Copy Markdown

Comparing: 9c3de25...3ceb237

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 135.47 kB 135.47 kB = 43.41 kB 43.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 147.73 kB 147.73 kB = 47.17 kB 47.17 kB
facebook-www/ReactDOM-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
facebook-www/ReactDOM-prod.modern.js = 477.00 kB 477.00 kB = 85.24 kB 85.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 3ceb237

@eps1lon eps1lon marked this pull request as ready for review December 11, 2020 06:54
@eps1lon eps1lon force-pushed the test/exhaustive-deps-generic-args branch from 639b21f to 6c6ee10 Compare April 8, 2021 09:08
@eps1lon eps1lon force-pushed the test/exhaustive-deps-generic-args branch from 6c6ee10 to f8eea13 Compare June 30, 2021 12:27
@eps1lon eps1lon changed the base branch from master to main June 30, 2021 12:30
@stale

stale Bot commented Jan 8, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale Bot added the Resolution: Stale Automatically closed due to inactivity label Jan 8, 2022
@eps1lon

eps1lon commented Jan 9, 2022

Copy link
Copy Markdown
Collaborator Author

Bump

@stale stale Bot removed the Resolution: Stale Automatically closed due to inactivity label Jan 9, 2022
@eps1lon eps1lon force-pushed the test/exhaustive-deps-generic-args branch from cb3754f to 16dffb2 Compare July 2, 2022 07:16
@eps1lon eps1lon force-pushed the test/exhaustive-deps-generic-args branch from 16dffb2 to 3ceb237 Compare October 2, 2022 12:58
@eps1lon eps1lon changed the title exhaustive-deps: Add passing test for generic type arguments Add passing exhaustive-deps test for type parameters in TypeScript Mar 14, 2024
@eps1lon eps1lon force-pushed the test/exhaustive-deps-generic-args branch from 3ceb237 to 0b6074f Compare March 14, 2024 14:30
@react-sizebot

react-sizebot commented Mar 14, 2024

Copy link
Copy Markdown

Comparing: 9ffe910...0b6074f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.83 kB 176.83 kB = 54.91 kB 54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.55 kB 173.55 kB = 54.11 kB 54.11 kB
facebook-www/ReactDOM-prod.classic.js = 594.04 kB 594.04 kB = 104.37 kB 104.37 kB
facebook-www/ReactDOM-prod.modern.js = 577.30 kB 577.30 kB = 101.42 kB 101.42 kB
test_utils/ReactAllWarnings.js Deleted 66.87 kB 0.00 kB Deleted 16.36 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 66.87 kB 0.00 kB Deleted 16.36 kB 0.00 kB

Generated by 🚫 dangerJS against 0b6074f

@eps1lon eps1lon merged commit a540f53 into react:main Mar 14, 2024
@eps1lon eps1lon deleted the test/exhaustive-deps-generic-args branch March 14, 2024 14:41
@ztanner ztanner mentioned this pull request Mar 18, 2024
Closed
@gnoff gnoff mentioned this pull request Mar 25, 2024
Closed
gnoff added a commit to gnoff/next.js that referenced this pull request Mar 25, 2024
@gnoff
Update React from 14898b6a9 to e373190fa
1a2ce1f 
- react/react#28596
- react/react#28625
- react/react#28616
- react/react#28491
- react/react#28583
- react/react#28427
- react/react#28613
- react/react#28599
- react/react#28611
- react/react#28610
- react/react#28606
- react/react#28598
- react/react#28549
- react/react#28557
- react/react#28467
- react/react#28591
- react/react#28459
- react/react#28590
- react/react#28564
- react/react#28582
- react/react#28579
- react/react#28578
- react/react#28521
- react/react#28550
- react/react#28576
- react/react#28577
- react/react#28571
- react/react#28572
- react/react#28560
- react/react#28569
- react/react#28573
- react/react#28546
- react/react#28568
- react/react#28562
- react/react#28566
- react/react#28565
- react/react#28559
- react/react#28508
- react/react#20432
- react/react#28555
- react/react#24730
- react/react#28472
- react/react#27991
- react/react#28514
- react/react#28548
- react/react#28526
- react/react#28515
- react/react#28533
- react/react#28532
- react/react#28531
- react/react#28407
- react/react#28522
- react/react#28538
- react/react#28509
- react/react#28534
- react/react#28527
- react/react#28528
- react/react#28519
- react/react#28411
- react/react#28520
- react/react#28518
- react/react#28493
- react/react#28504
- react/react#28499
- react/react#28501
- react/react#28496
- react/react#28471
- react/react#28351
- react/react#28486
- react/react#28490
- react/react#28488
- react/react#28468
- react/react#28321
- react/react#28477
- react/react#28479
- react/react#28480
- react/react#28478
- react/react#28464
- react/react#28475
- react/react#28456
- react/react#28319
- react/react#28345
- react/react#28337
- react/react#28335
- react/react#28466
- react/react#28462
- react/react#28322
- react/react#28444
- react/react#28448
- react/react#28449
- react/react#28446
- react/react#28447
- react/react#24580
@ztanner ztanner mentioned this pull request Apr 2, 2024
Closed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@eps1lon @AndyPengc12
Add passing exhaustive-deps test for type parameters in TypeScript (r…
ec8bf4b 
…eact#20432)
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@eps1lon
Add passing exhaustive-deps test for type parameters in TypeScript (#…
88fb4cb 
…20432)

DiffTrain build for commit a540f53.
@eps1lon eps1lon mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed Component: ESLint Rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eps1lon @sizebot @react-sizebot @facebook-github-bot