feat: honor displayName of context types#18035
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3968e0b:
|
Details of bundled changes.Comparing: d2158d6...3968e0b react
Size changes (stable) |
Details of bundled changes.Comparing: d2158d6...3968e0b react
Size changes (experimental) |
ea82cd5 to
1c17554
Compare
Merged
1c17554 to
0728d1f
Compare
Collaborator
Author
|
Changed the testing approach and rebase. @bvaughn could you take a look? |
bvaughn
reviewed
Mar 4, 2020
bvaughn
left a comment
Contributor
There was a problem hiding this comment.
This looks good. One small request.
bvaughn
approved these changes
Mar 4, 2020
Contributor
|
I've had to revert this PR. Details are in #18223. |
trueadm
added a commit
that referenced
this pull request
Mar 5, 2020
eps1lon
added a commit
to eps1lon/react
that referenced
this pull request
Mar 5, 2020
…" (react#18223)" This reverts commit 3ee812e.
Contributor
|
Thanks, Dominic! |
bvaughn
pushed a commit
that referenced
this pull request
Mar 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Any component name in errors/warnings that occur during server-side rendering ignore the
displayName. However, react-devtools does use this property when computing the component name. The docs mention this property but are very specific about dev tools usage. Is this limitation intentional and if so: why?Test Plan
Tested by triggering a prop-types error.