[CMS PR 46174] Update the update SQL scripts and for new installations supports.sql#21
Merged
rdeutz merged 6 commits intordeutz:version-lookup-tagsfrom Oct 7, 2025
Conversation
rdeutz
added a commit
that referenced
this pull request
Jan 12, 2026
… tag name instead of the tag id (joomla#46174) * update sql * [CMS PR 46174] Update the update SQL scripts and for new installations supports.sql (#21) * Names quotes for column names * Remove some tabs * Use separate lines for closing brackets * Fix SQL error "operator does not exist" * Append only once to array * Update supports.sql for new installations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla#46174 .
Summary of Changes
This pull request (PR) adds missing names quotes for column names to the update SQL scripts added by the mentioned CMS PR.
In addition it fixes an SQL error in the update SQL script for PostgreSQL which comes from the suggested code being made for a database column of the jsonb type, but the CMS uses text columns. Therefore the type cast to jsonb has to be applied on the column before accessing the object property.
Then it adds a condition to the WHERE clause in the update SQL scripts to make sure the new array element is only appended when it does not exist in the array. This makes sure that it is not appended again and again when for some reason the script runs multiple times, e.g. after a failed update attempt.
Besides that there are 2 small code style changes for the update SQL script so the style is consistent.
Finally this PR adds the new lookup options also in the supports.sql scripts for new installations.