Simplify code since every Joomla app has a get method#15
Merged
rdeutz merged 1 commit intordeutz:cleaup_isAdmin_usefrom Feb 24, 2021
Merged
Conversation
rdeutz
pushed a commit
that referenced
this pull request
Apr 13, 2022
* Add some events when fetching media data * Use dispatcher to trigger event * Use an event instance * Class per event (#15) * Argument validations and getter (#16) * Class per event * Argument validations * global * Use result from events * Copy year * Use internal variable * void * adapt model * Validate events (#17) * Revert commit ec8b4c8 ccd02cb and 9a2a119 * Validate and immutable events * Update administrator/components/com_media/src/Event/FetchMediaFileEvent.php Co-authored-by: Harald Leithner <leithner@itronic.at> * Update administrator/components/com_media/src/Event/FetchMediaFilesEvent.php Co-authored-by: Harald Leithner <leithner@itronic.at> * Rename the events * Cleanup events Co-authored-by: Fedir Zinchuk <getthesite@gmail.com> Co-authored-by: Harald Leithner <leithner@itronic.at>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla#32356 .
Summary of Changes
See title.
I could not provide this change with the review function in that PR for the CMS because the change goes too much down below the changed code, so I could not select the code to be changed for a suggestion on GitHub.
Discussion see review comment joomla#32356 (comment) and below.