Skip to content

Update the remoteprocess/proc-maps crates#295

Merged
acj merged 3 commits intorbspy:masterfrom
benfred:update_remoteprocess
Mar 24, 2021
Merged

Update the remoteprocess/proc-maps crates#295
acj merged 3 commits intorbspy:masterfrom
benfred:update_remoteprocess

Conversation

@benfred
Copy link
Copy Markdown
Collaborator

@benfred benfred commented Mar 22, 2021

The latest remoteprocess code includes a workaround for the case where the linux kernel
was compiled without process_vm_readv support (by falling back to /proc/PID/mem:
benfred/read-process-memory#4).

Closes #196

The latest remoteprocess code includes a workaround for the case where the linux kernel
was compiled without process_vm_readv support (by falling back to /proc/PID/mem:
benfred/read-process-memory#4).

Closes rbspy#196
@benfred benfred marked this pull request as draft March 22, 2021 06:33
@acj
Copy link
Copy Markdown
Member

acj commented Mar 22, 2021

Thanks @benfred. I tried to do this upgrade the other day to fix a CI issue on Windows but didn't have time to sort out the type errors. Happy to work with you on this in whatever way makes sense.

@benfred
Copy link
Copy Markdown
Collaborator Author

benfred commented Mar 23, 2021

Thanks @acj!

The CI failures here were because we need https://github.com/rbspy/rbspy-testdata and https://github.com/rbspy/rbspy to use the exact same versions of remoteprocess in their Cargo.toml files. I've created a PR for the rbspy-testdata crate here: rbspy/rbspy-testdata#4 which will also need merged

I've pointed this PR to link to my fork - which I'm hoping will sort out the CI failures 🤞

@benfred benfred marked this pull request as ready for review March 23, 2021 01:32
@acj
Copy link
Copy Markdown
Member

acj commented Mar 23, 2021

Ahh, good to know. I don't have a commit bit for rbspy-testdata, but the changes LGTM both there and here.

The Travis musl build has been consistently failing recently, and we're planning to migrate that build to GH Actions soon, so it doesn't need to be a blocker imo.

@jvns
Copy link
Copy Markdown
Collaborator

jvns commented Mar 23, 2021

I merged the rbspy-testdata PR and gave both of you maintainer access on that repo

@acj acj mentioned this pull request Mar 24, 2021
@acj acj merged commit abc857d into rbspy:master Mar 24, 2021
acj added a commit that referenced this pull request Mar 27, 2021
- Merge pull request #295 from benfred/update_remoteprocess
- Merge pull request #285 from acj/add-ruby-3-support
- readme: Mention ruby-structs version parity in maintainer instructions
- Bump ruby-structs version to match rbspy
@benfred benfred deleted the update_remoteprocess branch March 28, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Function not implemented (os error 38)

3 participants