Skip to content

Add fotmob extension#8664

Merged
raycastbot merged 8 commits intoraycast:mainfrom
sonla58:ext/fotmob
Oct 18, 2023
Merged

Add fotmob extension#8664
raycastbot merged 8 commits intoraycast:mainfrom
sonla58:ext/fotmob

Conversation

@sonla58
Copy link
Contributor

@sonla58 sonla58 commented Oct 3, 2023

Description

Screencast

Checklist

- Update metadata
- hello world
@raycastbot raycastbot added the new extension Label for PRs with new extensions label Oct 3, 2023
@raycastbot
Copy link
Collaborator

Congratulation on your new Raycast extension! 🚀

We will review it shortly. Once the PR is approved and merged, the extension will be available on the Store.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

  • If you in Team Details enters letters the extension dies, could you handle this gracefully

fotmob 2023-10-11 at 09 13 22

  • The extensions suffer from Empty state flicker

  • Could you redraw the list after selecting the team as a favourite?

  • Could be nice if all actions panel items had icons

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

[Change Request](raycast#8664)
- [x] - If you in Team Details enters letters the extension dies, could you handle this gracefully
- [x] - The extensions suffer from [Empty state flicker](https://developers.raycast.com/basics/prepare-an-extension-for-store#empty-states)
- [x] - Could you redraw the list after selecting the team as a favorite?
- [x] - Could be nice if all actions panel items had icons
@sonla58
Copy link
Contributor Author

sonla58 commented Oct 18, 2023

Hi 👋

Thanks for your feedbacks.

I've applied all your feedback as well as fix some minor issues

  • - If you in Team Details enters letters the extension dies, could you handle this gracefully
  • - The extensions suffer from Empty state flicker
  • - Could you redraw the list after selecting the team as a favorite?
  • - Could be nice if all actions panel items had icons

Please take a look and hope this is okay for the first release version

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 4c0274d into raycast:main Oct 18, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/iamlas/fotmob

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new extension Label for PRs with new extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants