GIF Search: Better results and codebase revamp#11887
Conversation
|
Thank you for your contribution! 🎉 🔔 @josephschmitt @tmwrnr @j3lte @samuelkraft you might want to have a look. |
|
Edit: closed my PR because of this PR |
f22b880 to
e9101dd
Compare
|
@j3lte Could you test out this PR and let me know if it fixes what you initially fixed? This PR is revamping the codebase to make it easier to understand and simpler to maintain while still adding some nice features like caching the results. |
|
Wow @thomaslombart, that's a serious rewrite! Do I need to do anything to get it working, I end up here as soon as I open the extension |
|
I can't reproduce it… Could you post a recording to better see what happens? Is it the same if you switch to the Tenor provider? |
|
@thomaslombart if you look at the error Edit: works fine for me, so it might just have been a hiccup... |
|
I'm not sure what happened; it seems to be working much better now. I ensured that I could open the URL, so I don't know what caused it. The search works SO much better than previous, well done @thomaslombart |
|
Echoing this, great work @thomaslombart! My only nit is regarding the empty states, on initial load we display a flickering empty state even for the services that automatically populates the list: The empty state for when you get 0 hits on search is also the same generic one, instead of saying "No Results": |
josephschmitt
left a comment
There was a problem hiding this comment.
This is a big change, nice work @thomaslombart! I haven't been able to review every line contributed, but directionally this looks good to me and as long as it's well-tested I'm comfortable with it getting merged.
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |



Description
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder