Skip to content

Update gif-search extension#11794

Closed
j3lte wants to merge 2 commits intoraycast:mainfrom
j3lte:ext/gif-search
Closed

Update gif-search extension#11794
j3lte wants to merge 2 commits intoraycast:mainfrom
j3lte:ext/gif-search

Conversation

@j3lte
Copy link
Contributor

@j3lte j3lte commented Apr 13, 2024

Description

This update changes a couple of things, but mainly improve loading of GIFs by:

  • Only load more gifs if the list isn't loading (to make sure we don't do multiple requests at once that overwrite the state)
  • Implement AbortController logic

This also meant I had to copy part of the Giphy JS library to a local version, because the library doesn't support AbortController.signal in their API.

This should also fix #11760 and improve the user experience

Screencast

Checklist

- Make gif search better
- Initial commit
@j3lte j3lte requested a review from samuelkraft as a code owner April 13, 2024 11:14
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: gif-search Issues related to the gif-search extension OP is contributor The OP of the PR is a contributor of the extension labels Apr 13, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Apr 13, 2024

Thank you for your contribution! 🎉

🔔 @josephschmitt @tmwrnr @samuelkraft you might want to have a look.

@j3lte
Copy link
Contributor Author

j3lte commented Apr 22, 2024

Closing PR because of #11887

@j3lte j3lte closed this Apr 22, 2024
@j3lte j3lte deleted the ext/gif-search branch April 23, 2024 14:58
@j3lte j3lte restored the ext/gif-search branch April 23, 2024 14:59
@j3lte j3lte deleted the ext/gif-search branch April 23, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: gif-search Issues related to the gif-search extension OP is contributor The OP of the PR is a contributor of the extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GIF Search] ... Doesn't show any gif's sometimes when searching for stuff

3 participants