This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Pop kwargs to support LightningCLI#154
Merged
amogkam merged 9 commits intoray-project:mainfrom May 23, 2022
Merged
Conversation
Yard1
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151.
As discussed in #151, LightningCLI does not support kwargs well, and assume kwargs are all passed into the superclass even though that's not necessarily the case. We do a small workaround here to pop certain values from kwargs to unblock using
RayPluginwith LightningCLI until the actual issue is fixed upstream in PTL.