Skip to content

[Streaming] fix streaming ci#9675

Merged
raulchen merged 42 commits intoray-project:masterfrom
antgroup:fix_streaming_ut
Sep 8, 2020
Merged

[Streaming] fix streaming ci#9675
raulchen merged 42 commits intoray-project:masterfrom
antgroup:fix_streaming_ut

Conversation

@chaokunyang
Copy link
Copy Markdown
Member

@chaokunyang chaokunyang commented Jul 24, 2020 •
edited
Loading

Why are these changes needed?

  • Fix streaming proto import failed
  • FixsubmitActorTask failed
F0724 15:01:37.418994 11010 2849297280 id.h:426]  Check failed: binary.size() == T::Size() || binary.size() == 0 expected size is 20, but got 3
*** Check failure stack trace: ***
    @        0x10287f1b2  google::LogMessage::~LogMessage()
    @        0x10284f255  ray::RayLog::~RayLog()
    @        0x1022fc3ea  ray::BaseID<>::FromBinary()
    @        0x10281b7e4  ray::TaskSpecification::ArgId()
    @        0x102431591  ray::TaskManager::AddPendingTask()
    @        0x1023b0a79  ray::CoreWorker::SubmitActorTask()
    @        0x1866cbac9  ray::streaming::Transport::SendInternal()
    @        0x1866cc1a2  ray::streaming::Transport::SendForResult()
    @        0x1866cc929  ray::streaming::Transport::SendForResultWithRetry()
    @        0x1866c4aac  ray::streaming::UpstreamQueueMessageHandler::CheckQueueSync()
    @        0x1866c515d  ray::streaming::UpstreamQueueMessageHandler::WaitQueues()
    @        0x1866a043c  ray::streaming::StreamingQueueProducer::CreateQueue()
    @        0x18669fe35  ray::streaming::StreamingQueueProducer::CreateTransferChannel()
    @        0x1866b2c60  ray::streaming::DataWriter::InitChannel()
    @        0x1866b2f34  ray::streaming::DataWriter::Init()
    @        0x18668bf07  __pyx_pf_3ray_9streaming_10_streaming_10DataWriter_2create()

Related issue number

#9152

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jul 24, 2020

Can one of the admins verify this patch?

@chaokunyang chaokunyang mentioned this pull request Jul 27, 2020
Closed
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jul 27, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/28998/
Test FAILed.

@chaokunyang chaokunyang changed the title [Streaming] fix replace proto import [Streaming] fix streaming ci Jul 28, 2020
@chaokunyang chaokunyang requested review from raulchen, robertnishihara and stephanie-wang and removed request for raulchen July 28, 2020 03:24
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jul 28, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29033/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jul 28, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29034/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jul 28, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29038/
Test FAILed.

ashione
ashione reviewed Jul 30, 2020
View reviewed changes
robertnishihara
robertnishihara reviewed Aug 3, 2020
View reviewed changes
robertnishihara
robertnishihara reviewed Aug 3, 2020
View reviewed changes
robertnishihara
robertnishihara reviewed Aug 3, 2020
View reviewed changes
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Aug 3, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29297/
Test FAILed.

@lixin-wei lixin-wei mentioned this pull request Aug 11, 2020
Merged
6 tasks
@stephanie-wang stephanie-wang self-assigned this Aug 11, 2020
@chaokunyang
Copy link
Copy Markdown
Member Author

chaokunyang commented Sep 4, 2020

@stephanie-wang @raulchen I believe the symbols conflict has be resolved. Could you review again and merge it?

@chaokunyang
Copy link
Copy Markdown
Member Author

chaokunyang commented Sep 4, 2020

Sorry for delaying this so long, we just haven't figured out a better way

stephanie-wang
stephanie-wang reviewed Sep 4, 2020
View reviewed changes
stephanie-wang
stephanie-wang reviewed Sep 4, 2020
View reviewed changes
@stephanie-wang
Copy link
Copy Markdown
Contributor

stephanie-wang commented Sep 4, 2020

Sorry for delaying this so long, we just haven't figured out a better way

No worries. It looks good, just had some comments on naming.

@raulchen
Copy link
Copy Markdown
Contributor

raulchen commented Sep 5, 2020

@chaokunyang CI is all red, can you check that?

@raulchen raulchen merged commit 3645a05 into ray-project:master Sep 8, 2020
@raulchen raulchen deleted the fix_streaming_ut branch September 8, 2020 14:21
rkooo567 added a commit to rkooo567/ray that referenced this pull request Sep 8, 2020
@rkooo567
Revert "[Streaming] fix streaming ci (ray-project#9675)"
296bc21 
This reverts commit 3645a05.
rkooo567 added a commit that referenced this pull request Sep 9, 2020
@rkooo567
Revert "[Streaming] fix streaming ci (#9675)" (#10656)
b7040f1 
This reverts commit 3645a05.
chaokunyang added a commit to antgroup/ant-ray that referenced this pull request Sep 9, 2020
@chaokunyang
Revert "Revert "[Streaming] fix streaming ci (ray-project#9675)" (ray…
f839a4f 
…-project#10656)"

This reverts commit b7040f1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertnishihara robertnishihara robertnishihara left review comments

@stephanie-wang stephanie-wang stephanie-wang left review comments

@ashione ashione ashione left review comments

@raulchen raulchen raulchen approved these changes

@zhijunfu zhijunfu Awaiting requested review from zhijunfu

Assignees

@stephanie-wang stephanie-wang

Labels

@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@chaokunyang @AmplabJenkins @stephanie-wang @raulchen @robertnishihara @ashione @lixin-wei