Skip to content

[tune] Fail Fast#7528

Merged
richardliaw merged 13 commits intoray-project:masterfrom
richardliaw:fix-hyperband
Mar 26, 2020
Merged

[tune] Fail Fast#7528
richardliaw merged 13 commits intoray-project:masterfrom
richardliaw:fix-hyperband

Conversation

@richardliaw
Copy link
Copy Markdown
Contributor

@richardliaw richardliaw commented Mar 10, 2020 •
edited
Loading

Why are these changes needed?

Enables experiments to fail very quickly.

Related issue number

Waiting on #7719

Checks

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 10, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22934/
Test FAILed.

@ujvl ujvl mentioned this pull request Mar 11, 2020
Merged
3 tasks
richardliaw and others added 3 commits March 23, 2020 16:18
@richardliaw richardliaw changed the title [tune] Hyperband Error Fix [tune] Fail Fast Mar 24, 2020
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 24, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23627/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 24, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23629/
Test PASSed.

@richardliaw richardliaw marked this pull request as ready for review March 25, 2020 03:39
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 25, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23677/
Test PASSed.

ujvl
ujvl reviewed Mar 26, 2020
View reviewed changes
python/ray/tune/trial_runner.py
logger.info("All trials stopped due to ``stopper.stop_all``.")
[
self.trial_executor.stop_trial(t) for t in self._trials
if t.status is not Trial.ERROR
Copy link
Copy Markdown
Contributor

@ujvl ujvl Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
if t.status is not Trial.ERROR
if t.is_finished()

might read more clearly

Copy link
Copy Markdown
Contributor Author

@richardliaw richardliaw Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's actually not the same; you need to terminate paused ones too.

@richardliaw richardliaw merged commit ca6eabc into ray-project:master Mar 26, 2020
@richardliaw richardliaw deleted the fix-hyperband branch March 26, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ujvl ujvl ujvl approved these changes

Assignees

@ujvl ujvl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richardliaw @AmplabJenkins @ujvl @ijrsvt