Skip to content

[tune] Cancel Experiment via Client#7719

Merged
richardliaw merged 7 commits intoray-project:masterfrom
richardliaw:tune-cancel
Mar 25, 2020
Merged

[tune] Cancel Experiment via Client#7719
richardliaw merged 7 commits intoray-project:masterfrom
richardliaw:tune-cancel

Conversation

@richardliaw
Copy link
Copy Markdown
Contributor

@richardliaw richardliaw commented Mar 23, 2020 •
edited
Loading

Why are these changes needed?

Expose an API to cancel the experiment.

Related issue number

Closes #7720

Checks

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 24, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23614/
Test FAILed.

richardliaw
richardliaw commented Mar 24, 2020
View reviewed changes
@richardliaw richardliaw marked this pull request as ready for review March 24, 2020 00:17
@richardliaw richardliaw requested a review from ijrsvt March 24, 2020 00:17
@ijrsvt @richardliaw
Update python/ray/tune/tests/test_tune_server.py
ccc8af4 
Co-Authored-By: Richard Liaw <rliaw@berkeley.edu>
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 24, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23618/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 24, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23620/
Test PASSed.

richardliaw
richardliaw commented Mar 24, 2020
View reviewed changes
richardliaw
richardliaw commented Mar 24, 2020
View reviewed changes
ujvl
ujvl reviewed Mar 24, 2020
View reviewed changes
python/ray/tune/trial_runner.py
self._stop_queue.append(trial)

def _process_requests(self):
def request_stop_experiment(self):
Copy link
Copy Markdown
Contributor

@ujvl ujvl Mar 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: documentation explaining behavior (eg when the request will actually be processed)

@richardliaw richardliaw mentioned this pull request Mar 24, 2020
Merged
6 tasks
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 24, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23625/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 24, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23626/
Test PASSed.

@richardliaw richardliaw merged commit 54a892b into ray-project:master Mar 25, 2020
@richardliaw richardliaw deleted the tune-cancel branch March 25, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ujvl ujvl ujvl approved these changes

@ijrsvt ijrsvt ijrsvt approved these changes

Assignees

@ujvl ujvl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tune] Should include pandas in the requirements

4 participants

@richardliaw @AmplabJenkins @ujvl @ijrsvt