Remove python/__init__.py#7361
Merged
pcmoritz merged 1 commit intoray-project:masterfrom Feb 28, 2020
Merged
Conversation
ray-project#7273)" This partially reverts commit 357232d. The addition of python/__init__.py broke the build on Windows. However, this is difficult to notice because Bazel doesn't seem to notice this dependency. You first have to go to a commit that fails on this issue, and then try to re-build this commit, so that Bazel actually performs a rebuild. A useful command-line for triggering the exact build i: bazel build --compile_one_dependency //:python/ray/_raylet.pyx
|
Can one of the admins verify this patch? |
|
Test FAILed. |
ffbin
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 20, 2020
ray-project#7273)" (ray-project#7361) This partially reverts commit 357232d. The addition of python/__init__.py broke the build on Windows. However, this is difficult to notice because Bazel doesn't seem to notice this dependency. You first have to go to a commit that fails on this issue, and then try to re-build this commit, so that Bazel actually performs a rebuild. A useful command-line for triggering the exact build i: bazel build --compile_one_dependency //:python/ray/_raylet.pyx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 357232d.
Why are these changes needed?
The addition of
python/__init__.pybroke the build on Windows. However, this is difficult to notice because Bazel doesn't seem to notice this dependency. You first have to go to a commit that fails on this issue, and then try to re-build this commit, so that Bazel actually performs a rebuild.A useful command-line for triggering the exact build is:
Related issue number
#631, #7273
Checks
scripts/format.shto lint the changes in this PR.