[RLlib] Fix SAC bug (twin Q not used for min'ing over both Q-nets in loss func).#7354
Merged
ericl merged 1 commit intoray-project:masterfrom Feb 27, 2020
Conversation
ericl
approved these changes
Feb 27, 2020
|
Can one of the admins verify this patch? |
|
Test PASSed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the SAC loss function, we do not use the twin-Q net's output to minimize over Q/twin-Q values (as described in the paper).
Related issue number
Checks
scripts/format.shto lint the changes in this PR.