[RLlib] rollout.py; make video-recording options more intuitive and add warnings/errors (issue 7121).#7347
Merged
ericl merged 3 commits intoray-project:masterfrom Feb 27, 2020
Conversation
|
Can one of the admins verify this patch? |
|
Test FAILed. |
ericl
approved these changes
Feb 27, 2020
|
Test FAILed. |
ffbin
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 20, 2020
…dd warnings/errors (issue 7121). (ray-project#7347)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the command line options for
rllib rolloutare not intuitive when one is trying to record videos (certain options must be present aside from the --monitor flag in order for this to work, but it's not communicated via errors/warnings). This PR closes a related issue #7121 .#7121
Closes #7121
scripts/format.shto lint the changes in this PR.