Deprecate non-direct-call API from Python#7336
Merged
edoakes merged 1 commit intoray-project:masterfrom Feb 27, 2020
Merged
Conversation
|
Can one of the admins verify this patch? |
ericl
approved these changes
Feb 26, 2020
|
Test FAILed. |
ffbin
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We now have two releases that use the direct call codepath by default, so we can and should remove the previous codepath to clean up the code and not hinder development. This is just a first pass that removes the Python code to toggle no-direct-call on. Unfortunately we cannot remove it from the backend yet (need to port actor reconstruction).
Checks
scripts/format.shto lint the changes in this PR.