Skip to content

[tune] fix hparams for tbx#7312

Merged
richardliaw merged 8 commits intoray-project:masterfrom
richardliaw:tune-hparams-fix
Feb 28, 2020
Merged

[tune] fix hparams for tbx#7312
richardliaw merged 8 commits intoray-project:masterfrom
richardliaw:tune-hparams-fix

Conversation

@richardliaw
Copy link
Copy Markdown
Contributor

@richardliaw richardliaw commented Feb 25, 2020 •
edited
Loading

Why are these changes needed?

Filters out histograms for proper hparams view.

Related issue number

Closes #7300

Checks

@richardliaw richardliaw changed the title [tune] fix hparams [tune] fix hparams for tbx Feb 25, 2020
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Feb 25, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22366/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Feb 25, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22367/
Test FAILed.

@richardliaw richardliaw requested a review from ericl February 25, 2020 17:46
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Feb 25, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22393/
Test PASSed.

ericl
ericl reviewed Feb 25, 2020
View reviewed changes
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Feb 25, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22403/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Feb 26, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22409/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Feb 27, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22476/
Test FAILed.

richardliaw
richardliaw commented Feb 28, 2020
View reviewed changes
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Feb 28, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22537/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Feb 28, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22538/
Test PASSed.

@richardliaw richardliaw merged commit fb73d51 into ray-project:master Feb 28, 2020
@richardliaw richardliaw deleted the tune-hparams-fix branch February 28, 2020 19:51
ffbin pushed a commit to antgroup/ant-ray that referenced this pull request Mar 20, 2020
@richardliaw
[tune] fix hparams for tbx (ray-project#7312)
d74d922 
* fix

* test_hist

* remove unnecessary value check

* pbt

* queue

* skip_for_now

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericl ericl ericl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tune] HParams Dashboard shows no data when using Histogram Dashboard.

3 participants

@richardliaw @AmplabJenkins @ericl