[Data] Update exclude_resources docs to reflect Train autoscaling coordinator changes#61990
Merged
justinvyu merged 1 commit intoray-project:masterfrom Mar 24, 2026
Merged
Conversation
Signed-off-by: JasonLi1909 <jasli1909@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request clarifies the documentation for the exclude_resources parameter in both the reStructuredText documentation and the Python docstring, specifically regarding its interaction with Ray Train. The review suggests an improvement for the Python docstring's formatting to ensure correct rendering and readability, recommending proper indentation for continuation lines of list items.
alexeykudinkin
approved these changes
Mar 23, 2026
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Mar 25, 2026
…rdinator changes (ray-project#61990) After ray-project#61703, Ray Train no longer adds training resources to `exclude_resources`. Instead, training resources are registered directly with the `AutoscalingCoordinator`. The docs still said training resources are "automatically excluded," which is misleading. This updates the wording to reflect the new behavior. Signed-off-by: JasonLi1909 <jasli1909@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #61703, Ray Train no longer adds training resources to
exclude_resources. Instead, training resources are registered directly with theAutoscalingCoordinator. The docs still said training resources are "automatically excluded," which is misleading. This updates the wording to reflect the new behavior.Changes
exclude_resourcesnote indoc/source/data/execution-configurations.rstandExecutionOptionsdocstring inexecution_options.pyto clarify that training resources are automatically reserved without needingexclude_resources.Tests
Doc-only change — no new tests needed.