[Data] Refactor DataContext to hold execution callback classes instead of instances#61293
Merged
bveeramani merged 14 commits intoray-project:masterfrom Feb 25, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request continues the refactoring of the execution callback system by moving to a static, class-based registration in DataContext. The changes in ray.data.context are clear and introduce a factory for collecting callback classes. Additionally, the SGLang example is significantly improved to properly support multi-GPU configurations (TP/PP), with corresponding documentation and test updates. My review includes a suggestion to simplify and improve the correctness of resource bundle creation in the SGLang engine, aligning it with patterns used elsewhere in the codebase.
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
e51e942 to
1633933
Compare
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
bveeramani
reviewed
Feb 25, 2026
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
bveeramani
approved these changes
Feb 25, 2026
bveeramani
pushed a commit
that referenced
this pull request
Mar 25, 2026
…kage (#61405) Larger Issue Refactored the execution callback system from dynamic, per-job injection to static, eager initialization. DataContext now serves as a stateless registry of callback factories, enabling the StreamingExecutor to load all callbacks at startup. Each callback then self-configures or no-ops based on the runtime environment. Context This is Part 3 of a four-part change set intended to resolve the issue described above. Part 1 diff: #60480 Part 2 diff: #61293 Closes #60279. --------- Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com> Signed-off-by: Limark Dcunha <83493294+limarkdcunha@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Larger Issue
Refactored the execution callback system from dynamic, per-job injection to static, eager initialization. DataContext now serves as a stateless registry of callback factories, enabling the StreamingExecutor to load all callbacks at startup. Each callback then self-configures or no-ops based on the runtime environment.
Context
This is Part 2 of a four-part change set intended to resolve the issue described above.
Part 1 diff: #60480
Closes #60279.