Skip to content

[Data] Fix wrong type hint of other dataset in zip & union#60653

Merged
bveeramani merged 2 commits intoray-project:masterfrom
owenowenisme:data/fix-union-and-zip-other-ds-type
Feb 5, 2026
Merged

[Data] Fix wrong type hint of other dataset in zip & union#60653
bveeramani merged 2 commits intoray-project:masterfrom
owenowenisme:data/fix-union-and-zip-other-ds-type

Conversation

@owenowenisme
Copy link
Copy Markdown
Member

@owenowenisme owenowenisme commented Feb 2, 2026 •
edited
Loading

Description

Fix incorrect type hints and docstrings for Dataset.zip and Dataset.union to correctly reflect varargs usage.

Related issues

Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234".

Additional information

Optional: Add implementation details, API changes, usage examples, screenshots, etc.

@owenowenisme owenowenisme added data Ray Data-related issues go add ONLY when ready to merge, run all tests labels Feb 2, 2026
@owenowenisme owenowenisme marked this pull request as ready for review February 2, 2026 06:17
@owenowenisme owenowenisme requested a review from a team as a code owner February 2, 2026 06:17
gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes the type hints for variadic arguments in the Dataset.union and Dataset.zip methods. The change from *other: List["Dataset"] to *other: "Dataset" is accurate, as *args collects arguments into a tuple, not a list. The corresponding docstring updates in both methods and the removal of the pydoclint error from the baseline file are also correct and improve consistency. The changes are well-contained and improve code quality and correctness. I have no further comments.

@owenowenisme owenowenisme changed the title [Data] Fix wrong type hit of other dataset in zip & union [Data] Fix wrong type hint of other dataset in zip & union Feb 2, 2026
@owenowenisme
update
38cef3d 
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
@owenowenisme owenowenisme force-pushed the data/fix-union-and-zip-other-ds-type branch from f8a9e55 to 38cef3d Compare February 2, 2026 22:52
@bveeramani bveeramani merged commit c6fdd28 into ray-project:master Feb 5, 2026
6 checks passed
tiennguyentony pushed a commit to tiennguyentony/ray that referenced this pull request Feb 7, 2026
@owenowenisme @tiennguyentony
[Data] Fix wrong type hint of other dataset in zip & union (ray-pro…
3be4491 
…ject#60653)

## Description
Fix incorrect type hints and docstrings for Dataset.zip and
Dataset.union to correctly reflect varargs usage.

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Signed-off-by: tiennguyentony <46289799+tiennguyentony@users.noreply.github.com>
tiennguyentony pushed a commit to tiennguyentony/ray that referenced this pull request Feb 7, 2026
@owenowenisme @tiennguyentony
[Data] Fix wrong type hint of other dataset in zip & union (ray-pro…
aac586b 
…ject#60653)


## Description
Fix incorrect type hints and docstrings for Dataset.zip and
Dataset.union to correctly reflect varargs usage.

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Signed-off-by: tiennguyentony <46289799+tiennguyentony@users.noreply.github.com>
tiennguyentony pushed a commit to tiennguyentony/ray that referenced this pull request Feb 7, 2026
@owenowenisme
[Data] Fix wrong type hint of other dataset in zip & union (ray-pro…
0dd6461 
…ject#60653)


## Description
Fix incorrect type hints and docstrings for Dataset.zip and
Dataset.union to correctly reflect varargs usage.

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
elliot-barn pushed a commit that referenced this pull request Feb 9, 2026
@owenowenisme @elliot-barn
[Data] Fix wrong type hint of other dataset in zip & union (#60653)
3e277bb 
## Description
Fix incorrect type hints and docstrings for Dataset.zip and
Dataset.union to correctly reflect varargs usage.

## Related issues
> Link related issues: "Fixes #1234", "Closes #1234", or "Related to
#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Feb 9, 2026
@owenowenisme @elliot-barn
[Data] Fix wrong type hint of other dataset in zip & union (#60653)
dec4ef8 
## Description
Fix incorrect type hints and docstrings for Dataset.zip and
Dataset.union to correctly reflect varargs usage.

## Related issues
> Link related issues: "Fixes #1234", "Closes #1234", or "Related to
#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Kunchd pushed a commit to Kunchd/ray that referenced this pull request Feb 17, 2026
@owenowenisme
[Data] Fix wrong type hint of other dataset in zip & union (ray-pro…
5085a2a 
…ject#60653)

## Description
Fix incorrect type hints and docstrings for Dataset.zip and
Dataset.union to correctly reflect varargs usage.

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
ans9868 pushed a commit to ans9868/ray that referenced this pull request Feb 18, 2026
@owenowenisme @ans9868
[Data] Fix wrong type hint of other dataset in zip & union (ray-pro…
7194504 
…ject#60653)

## Description
Fix incorrect type hints and docstrings for Dataset.zip and
Dataset.union to correctly reflect varargs usage.

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Signed-off-by: Adel Nour <ans9868@nyu.edu>
Aydin-ab pushed a commit to kunling-anyscale/ray that referenced this pull request Feb 20, 2026
@owenowenisme @Aydin-ab
[Data] Fix wrong type hint of other dataset in zip & union (ray-pro…
09c1df2 
…ject#60653)

## Description
Fix incorrect type hints and docstrings for Dataset.zip and
Dataset.union to correctly reflect varargs usage.

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
@owenowenisme @peterxcli
[Data] Fix wrong type hint of other dataset in zip & union (ray-pro…
1c92235 
…ject#60653)

## Description
Fix incorrect type hints and docstrings for Dataset.zip and
Dataset.union to correctly reflect varargs usage.

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
@owenowenisme @peterxcli
[Data] Fix wrong type hint of other dataset in zip & union (ray-pro…
56c5b94 
…ject#60653)

## Description
Fix incorrect type hints and docstrings for Dataset.zip and
Dataset.union to correctly reflect varargs usage.

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bveeramani bveeramani bveeramani approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

data Ray Data-related issues go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ray fails to serialize self-reference objects

2 participants

@owenowenisme @bveeramani